summaryrefslogtreecommitdiff
path: root/ext/tidy/tidy.c
diff options
context:
space:
mode:
authorAlex Dowad <alexinbeijing@gmail.com>2020-04-08 13:19:39 +0200
committerNikita Popov <nikita.ppv@gmail.com>2020-04-14 11:22:23 +0200
commit80598f12507c5cbde04163289e4d2575f05d2a0c (patch)
treef5d3c26400dcb577e6c508469d1de086f5fda695 /ext/tidy/tidy.c
parentd4471c6aaecab2f1cc467ea8e92040c73685bd21 (diff)
downloadphp-git-80598f12507c5cbde04163289e4d2575f05d2a0c.tar.gz
Syntax errors caused by unclosed {, [, ( mention specific location
Aside from a few very specific syntax errors for which detailed exceptions are thrown, generally PHP just emits the default error messages generated by bison on syntax error. These messages are very uninformative; they just say "Unexpected ... at line ...". This is most problematic with constructs which can span an arbitrary number of lines, such as blocks of code delimited by { }, 'if' conditions delimited by ( ), and so on. If a closing delimiter is missed, the block will run for the entire remainder of the source file (which could be thousands of lines), and then at the end, a parse error will be thrown with the dreaded words: "Unexpected end of file". Therefore, track the positions of opening and closing delimiters and ensure that they match up correctly. If any mismatch or missing delimiter is detected, immediately throw a parse error which points the user to the offending line. This is best done in the *lexer* and not in the parser. Thanks to Nikita Popov and George Peter Banyard for suggesting improvements. Fixes bug #79368. Closes GH-5364.
Diffstat (limited to 'ext/tidy/tidy.c')
0 files changed, 0 insertions, 0 deletions