summaryrefslogtreecommitdiff
path: root/ext/xml
diff options
context:
space:
mode:
authorChristoph M. Becker <cmbecker69@gmx.de>2019-09-03 13:11:08 +0200
committerChristoph M. Becker <cmbecker69@gmx.de>2019-09-03 13:12:05 +0200
commit37713c80e49b37833dfd48a7f880fa9516ee0dd2 (patch)
tree964de519f933a7168335052b3f8482f9adbf58b0 /ext/xml
parent7e8b3dd542ff71bba7636d5fa30263af4e2bc310 (diff)
downloadphp-git-37713c80e49b37833dfd48a7f880fa9516ee0dd2.tar.gz
Don't explicitly set return value on ZPP failure in ext/xml
Failing ZPP throws as of PHP 8.0.0, so explicitly setting a return value is useless, and also slightly confusing.
Diffstat (limited to 'ext/xml')
-rw-r--r--ext/xml/xml.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ext/xml/xml.c b/ext/xml/xml.c
index d6e91b69ce..4da8f54c5c 100644
--- a/ext/xml/xml.c
+++ b/ext/xml/xml.c
@@ -1065,7 +1065,7 @@ static void php_xml_parser_create_impl(INTERNAL_FUNCTION_PARAMETERS, int ns_supp
XML_Char *encoding;
if (zend_parse_parameters(ZEND_NUM_ARGS(), (ns_support ? "|ss": "|s"), &encoding_param, &encoding_param_len, &ns_param, &ns_param_len) == FAILURE) {
- RETURN_FALSE;
+ return;
}
if (encoding_param != NULL) {