summaryrefslogtreecommitdiff
path: root/ext/xml
diff options
context:
space:
mode:
authorNikita Popov <nikita.ppv@gmail.com>2020-04-06 12:46:52 +0200
committerNikita Popov <nikita.ppv@gmail.com>2020-07-31 15:53:36 +0200
commitd92229d8c78aac25925284e23aa7903dca9ed005 (patch)
treeec01712dbe44a11cb7368492388cb39ab04dac17 /ext/xml
parent9a71d47d7334b9e2f83db48498047750c04cd192 (diff)
downloadphp-git-d92229d8c78aac25925284e23aa7903dca9ed005.tar.gz
Implement named parameters
From an engine perspective, named parameters mainly add three concepts: * The SEND_* opcodes now accept a CONST op2, which is the argument name. For now, it is looked up by linear scan and runtime cached. * This may leave UNDEF arguments on the stack. To avoid having to deal with them in other places, a CHECK_UNDEF_ARGS opcode is used to either replace them with defaults, or error. * For variadic functions, EX(extra_named_params) are collected and need to be freed based on ZEND_CALL_HAS_EXTRA_NAMED_PARAMS. RFC: https://wiki.php.net/rfc/named_params Closes GH-5357.
Diffstat (limited to 'ext/xml')
-rw-r--r--ext/xml/xml.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/ext/xml/xml.c b/ext/xml/xml.c
index 476d77444c..c5d3f71079 100644
--- a/ext/xml/xml.c
+++ b/ext/xml/xml.c
@@ -464,6 +464,7 @@ static void xml_call_handler(xml_parser *parser, zval *handler, zend_function *f
fci.retval = retval;
fci.param_count = argc;
fci.params = argv;
+ fci.named_params = NULL;
result = zend_call_function(&fci, NULL);
if (result == FAILURE) {