summaryrefslogtreecommitdiff
path: root/ext/xmlwriter/php_xmlwriter.c
diff options
context:
space:
mode:
authorChristoph M. Becker <cmbecker69@gmx.de>2020-01-29 18:23:51 +0100
committerChristoph M. Becker <cmbecker69@gmx.de>2020-01-30 13:04:57 +0100
commit8226e704e4e6066a5bd41b57b2934a3371896be2 (patch)
tree86fca74729179e8ebda16c108b1068f19579aaea /ext/xmlwriter/php_xmlwriter.c
parent494615fcb8c1fb5984e0e7d666e51a2dfc6bee55 (diff)
downloadphp-git-8226e704e4e6066a5bd41b57b2934a3371896be2.tar.gz
Fix #70078: XSL callbacks with nodes as parameter leak memory
The fix for bug #49634 solved a double-free by copying the node with `xmlDocCopyNodeList()`, but the copied node is later freed by calling `xmlFreeNode()` instead of `xmlFreeNodeList()`, thus leaking memory. However, there is no need to treat the node as node list, i.e. to copy also the node's siblings; just creating a recursive copy of the node with `xmlDocCopyNode()` is sufficient, while that also avoids the leak.
Diffstat (limited to 'ext/xmlwriter/php_xmlwriter.c')
0 files changed, 0 insertions, 0 deletions