summaryrefslogtreecommitdiff
path: root/ext/zip/lib
diff options
context:
space:
mode:
authorAnatol Belski <ab@php.net>2017-10-27 14:18:27 +0200
committerAnatol Belski <ab@php.net>2017-10-27 14:18:27 +0200
commit40f76c9f0c52658a65479fa01456376c870ed5c9 (patch)
tree530826bee07c5c0c9e4a52acbca0bd3d4d0f4935 /ext/zip/lib
parentf577a03c045e02b80ee0c3ed340bb186500a7342 (diff)
parent211dacd7b5c945580e763f7322be85b8be7d92ec (diff)
downloadphp-git-40f76c9f0c52658a65479fa01456376c870ed5c9.tar.gz
Merge branch 'PHP-7.1' into PHP-7.2
* PHP-7.1: Apply upstream patch for CVE-2017-14107 Backport and apply upstream patch for CVE-2017-14107
Diffstat (limited to 'ext/zip/lib')
-rw-r--r--ext/zip/lib/zip_open.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/ext/zip/lib/zip_open.c b/ext/zip/lib/zip_open.c
index d6209ee1e7..29409b747d 100644
--- a/ext/zip/lib/zip_open.c
+++ b/ext/zip/lib/zip_open.c
@@ -837,7 +837,12 @@ _zip_read_eocd64(zip_source_t *src, zip_buffer_t *buffer, zip_uint64_t buf_offse
zip_error_set(error, ZIP_ER_SEEK, EFBIG);
return NULL;
}
- if ((flags & ZIP_CHECKCONS) && offset+size != eocd_offset) {
+ if (offset+size > buf_offset + eocd_offset) {
+ /* cdir spans past EOCD record */
+ zip_error_set(error, ZIP_ER_INCONS, 0);
+ return NULL;
+ }
+ if ((flags & ZIP_CHECKCONS) && offset+size != buf_offset + eocd_offset) {
zip_error_set(error, ZIP_ER_INCONS, 0);
return NULL;
}