summaryrefslogtreecommitdiff
path: root/ext/zip
diff options
context:
space:
mode:
authorGeorge Peter Banyard <girgias@php.net>2020-08-28 15:41:27 +0200
committerGeorge Peter Banyard <girgias@php.net>2020-08-28 15:41:27 +0200
commitfa8d9b1183f961cb6e0f0ef5a2d1b1d3744fe35b (patch)
treea00044117c3f56969a7b77b466bbdbdd45d66db7 /ext/zip
parent7690439edd93bf9dc868cbc34a12fbad6b26e777 (diff)
downloadphp-git-fa8d9b1183f961cb6e0f0ef5a2d1b1d3744fe35b.tar.gz
Improve type declarations for Zend APIs
Voidification of Zend API which always succeeded Use bool argument types instead of int for boolean arguments Use bool return type for functions which return true/false (1/0) Use zend_result return type for functions which return SUCCESS/FAILURE as they don't follow normal boolean semantics Closes GH-6002
Diffstat (limited to 'ext/zip')
-rw-r--r--ext/zip/php_zip.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/ext/zip/php_zip.c b/ext/zip/php_zip.c
index 43c2da9af6..c1a569afec 100644
--- a/ext/zip/php_zip.c
+++ b/ext/zip/php_zip.c
@@ -1290,7 +1290,8 @@ PHP_FUNCTION(zip_entry_close)
RETURN_THROWS();
}
- RETURN_BOOL(SUCCESS == zend_list_close(Z_RES_P(zip_entry)));
+ zend_list_close(Z_RES_P(zip_entry));
+ RETURN_TRUE;
}
/* }}} */