summaryrefslogtreecommitdiff
path: root/ext
diff options
context:
space:
mode:
authorChristoph M. Becker <cmbecker69@gmx.de>2020-10-10 19:19:33 +0200
committerChristoph M. Becker <cmbecker69@gmx.de>2020-10-10 19:19:47 +0200
commit7d085c87acb8ee2579cc27e8e51310741cb56c55 (patch)
tree426d983aaa39447c6ef991572089e38b06ba4c72 /ext
parent2a545ba946033528d38ccfec46fdd592c1eb4857 (diff)
parentb2b9e2e87e780d814ffc6ceeaf1b546a14e76799 (diff)
downloadphp-git-7d085c87acb8ee2579cc27e8e51310741cb56c55.tar.gz
Merge branch 'PHP-7.4' into PHP-8.0
* PHP-7.4: Fix #80213: imap_mail_compose() segfaults on certain $bodies
Diffstat (limited to 'ext')
-rw-r--r--ext/imap/php_imap.c4
-rw-r--r--ext/imap/tests/bug80213.phpt21
2 files changed, 25 insertions, 0 deletions
diff --git a/ext/imap/php_imap.c b/ext/imap/php_imap.c
index 88ce679f3a..13c7bef42a 100644
--- a/ext/imap/php_imap.c
+++ b/ext/imap/php_imap.c
@@ -3195,6 +3195,7 @@ PHP_FUNCTION(imap_mail_compose)
if(Z_TYPE_P(pvalue) == IS_ARRAY) {
disp_param = tmp_param = NULL;
ZEND_HASH_FOREACH_STR_KEY_VAL(Z_ARRVAL_P(pvalue), key, disp_data) {
+ if (key == NULL) continue;
disp_param = mail_newbody_parameter();
disp_param->attribute = cpystr(ZSTR_VAL(key));
convert_to_string_ex(disp_data);
@@ -3227,6 +3228,7 @@ PHP_FUNCTION(imap_mail_compose)
if (Z_TYPE_P(pvalue) == IS_ARRAY) {
disp_param = tmp_param = NULL;
ZEND_HASH_FOREACH_STR_KEY_VAL(Z_ARRVAL_P(pvalue), key, disp_data) {
+ if (key == NULL) continue;
disp_param = mail_newbody_parameter();
disp_param->attribute = cpystr(ZSTR_VAL(key));
convert_to_string_ex(disp_data);
@@ -3295,6 +3297,7 @@ PHP_FUNCTION(imap_mail_compose)
if (Z_TYPE_P(pvalue) == IS_ARRAY) {
disp_param = tmp_param = NULL;
ZEND_HASH_FOREACH_STR_KEY_VAL(Z_ARRVAL_P(pvalue), key, disp_data) {
+ if (key == NULL) continue;
disp_param = mail_newbody_parameter();
disp_param->attribute = cpystr(ZSTR_VAL(key));
convert_to_string_ex(disp_data);
@@ -3327,6 +3330,7 @@ PHP_FUNCTION(imap_mail_compose)
if (Z_TYPE_P(pvalue) == IS_ARRAY) {
disp_param = tmp_param = NULL;
ZEND_HASH_FOREACH_STR_KEY_VAL(Z_ARRVAL_P(pvalue), key, disp_data) {
+ if (key == NULL) continue;
disp_param = mail_newbody_parameter();
disp_param->attribute = cpystr(ZSTR_VAL(key));
convert_to_string_ex(disp_data);
diff --git a/ext/imap/tests/bug80213.phpt b/ext/imap/tests/bug80213.phpt
new file mode 100644
index 0000000000..9a7961df77
--- /dev/null
+++ b/ext/imap/tests/bug80213.phpt
@@ -0,0 +1,21 @@
+--TEST--
+Bug #80213 (imap_mail_compose() segfaults on certain $bodies)
+--SKIPIF--
+<?php
+if (!extension_loaded('imap')) die('skip imap extension not available');
+?>
+--FILE--
+<?php
+$envelope = [];
+$body = [[
+ 'type.parameters' => ['param'],
+ 'disposition' => ['disp'],
+], [
+ 'type.parameters' => ['param'],
+ 'disposition' => ['disp'],
+]];
+imap_mail_compose($envelope, $body);
+echo "done\n";
+?>
+--EXPECT--
+done