summaryrefslogtreecommitdiff
path: root/main/php_open_temporary_file.c
diff options
context:
space:
mode:
authorIlia Alshanetsky <iliaa@php.net>2011-01-11 12:57:19 +0000
committerIlia Alshanetsky <iliaa@php.net>2011-01-11 12:57:19 +0000
commitd5af830385ccbf1000694ecdb6a5dcd63513a9f4 (patch)
treede897f6f77a2863e5d9ddee82d6e1a2a91c5b110 /main/php_open_temporary_file.c
parentf9c61024a516c65b0cf3e79836eaa5efd0a27e41 (diff)
downloadphp-git-d5af830385ccbf1000694ecdb6a5dcd63513a9f4.tar.gz
Added missing success check around chmod() for windows during temp file creation
Diffstat (limited to 'main/php_open_temporary_file.c')
-rw-r--r--main/php_open_temporary_file.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/main/php_open_temporary_file.c b/main/php_open_temporary_file.c
index a8ea24d1e1..458f2bf405 100644
--- a/main/php_open_temporary_file.c
+++ b/main/php_open_temporary_file.c
@@ -149,7 +149,11 @@ static int php_do_open_temporary_file(const char *path, const char *pfx, char **
if (GetTempFileName(new_state.cwd, pfx, 0, opened_path)) {
/* Some versions of windows set the temp file to be read-only,
* which means that opening it will fail... */
- VCWD_CHMOD(opened_path, 0600);
+ if (VCWD_CHMOD(opened_path, 0600)) {
+ efree(opened_path);
+ free(new_state.cwd);
+ return -1;
+ }
fd = VCWD_OPEN_MODE(opened_path, open_flags, 0600);
}