diff options
| author | Gustavo André dos Santos Lopes <cataphract@php.net> | 2011-02-01 18:11:16 +0000 |
|---|---|---|
| committer | Gustavo André dos Santos Lopes <cataphract@php.net> | 2011-02-01 18:11:16 +0000 |
| commit | c6ccc4328560799f8532e0dd14fecea46245db15 (patch) | |
| tree | 5393e1bc57758244af82e37a57182233594b5c46 /main/streams/filter.c | |
| parent | 44cd358f04249852e724c4288ef6b0584fad0354 (diff) | |
| download | php-git-c6ccc4328560799f8532e0dd14fecea46245db15.tar.gz | |
- Fixed several comparisons that always result in true of false
due to signedness of one of the operands, either by removing
dead code or fixing it.
- Thrown some comments around in php_stream_get_record.
- See http://www.mail-archive.com/internals@lists.php.net/msg49525.html
Diffstat (limited to 'main/streams/filter.c')
| -rw-r--r-- | main/streams/filter.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/main/streams/filter.c b/main/streams/filter.c index fb825f51e1..623c66f96d 100644 --- a/main/streams/filter.c +++ b/main/streams/filter.c @@ -360,7 +360,7 @@ PHPAPI int php_stream_filter_append_ex(php_stream_filter_chain *chain, php_strea php_stream_bucket_append(brig_inp, bucket TSRMLS_CC); status = filter->fops->filter(stream, filter, brig_inp, brig_outp, &consumed, PSFS_FLAG_NORMAL TSRMLS_CC); - if (stream->readpos + consumed > (uint)stream->writepos || consumed < 0) { + if (stream->readpos + consumed > (uint)stream->writepos) { /* No behaving filter should cause this. */ status = PSFS_ERR_FATAL; } |