diff options
| author | Nikita Popov <nikita.ppv@gmail.com> | 2019-09-30 18:27:31 +0200 |
|---|---|---|
| committer | Nikita Popov <nikita.ppv@gmail.com> | 2019-10-01 13:04:47 +0200 |
| commit | 4d49ec208e0f4d2307b4a4dfd6d5a69f6fb0a541 (patch) | |
| tree | a654324441d38bd459587384a58d981a1a756593 /sapi/fuzzer | |
| parent | b53d9528c22bae5cbb66bb1de5ed88d781872776 (diff) | |
| download | php-git-4d49ec208e0f4d2307b4a4dfd6d5a69f6fb0a541.tar.gz | |
Add --enable-fuzzer-msan flag
To build fuzzers with memory sanitizer.
Diffstat (limited to 'sapi/fuzzer')
| -rw-r--r-- | sapi/fuzzer/config.m4 | 34 |
1 files changed, 25 insertions, 9 deletions
diff --git a/sapi/fuzzer/config.m4 b/sapi/fuzzer/config.m4 index 5ce9390825..37945b8e9e 100644 --- a/sapi/fuzzer/config.m4 +++ b/sapi/fuzzer/config.m4 @@ -3,6 +3,13 @@ AC_MSG_CHECKING(for clang fuzzer SAPI) PHP_ARG_ENABLE([fuzzer],, [AS_HELP_STRING([--enable-fuzzer], [Build PHP as clang fuzzing test module (for developers)])], + [no], + [no]) + +PHP_ARG_ENABLE([fuzzer-msan],, + [AS_HELP_STRING([--enable-fuzzer-msan], + [Enable msan instead of asan/ubsan when fuzzing])], + [no], [no]) dnl For newer clang versions see https://llvm.org/docs/LibFuzzer.html#fuzzer-usage @@ -29,16 +36,25 @@ if test "$PHP_FUZZER" != "no"; then if test -z "$LIB_FUZZING_ENGINE"; then FUZZING_LIB="-fsanitize=fuzzer" FUZZING_CC="$CC" - dnl Don't include -fundefined in CXXFLAGS, because that would also require linking - dnl with a C++ compiler. AX_CHECK_COMPILE_FLAG([-fsanitize=fuzzer-no-link], [ - CFLAGS="$CFLAGS -fsanitize=fuzzer-no-link,address" - dnl Disable object-size sanitizer, because it is incompatible with our zend_function - dnl union, and this can't be easily fixed. - dnl We need to specify -fno-sanitize-recover=undefined here, otherwise ubsan warnings - dnl will not be considered failures by the fuzzer. - CFLAGS="$CFLAGS -fsanitize=undefined -fno-sanitize=object-size -fno-sanitize-recover=undefined" - CXXFLAGS="$CXXFLAGS -fsanitize=fuzzer-no-link,address" + CFLAGS="$CFLAGS -fsanitize=fuzzer-no-link" + CXXFLAGS="$CXXFLAGS -fsanitize=fuzzer-no-link" + + if test "$PHP_FUZZER_MSAN" = "yes"; then + CFLAGS="$CFLAGS -fsanitize=memory -fsanitize-memory-track-origins" + CXXFLAGS="$CXXFLAGS -fsanitize=memory -fsanitize-memory-track-origins" + else + CFLAGS="$CFLAGS -fsanitize=address" + CXXFLAGS="$CXXFLAGS -fsanitize=address" + + dnl Don't include -fundefined in CXXFLAGS, because that would also require linking + dnl with a C++ compiler. + dnl Disable object-size sanitizer, because it is incompatible with our zend_function + dnl union, and this can't be easily fixed. + dnl We need to specify -fno-sanitize-recover=undefined here, otherwise ubsan warnings + dnl will not be considered failures by the fuzzer. + CFLAGS="$CFLAGS -fsanitize=undefined -fno-sanitize=object-size -fno-sanitize-recover=undefined" + fi ],[ AC_MSG_ERROR(Compiler doesn't support -fsanitize=fuzzer-no-link) ]) |