diff options
| author | Christoph M. Becker <cmbecker69@gmx.de> | 2020-05-27 09:58:10 +0200 |
|---|---|---|
| committer | Christoph M. Becker <cmbecker69@gmx.de> | 2020-06-05 11:17:05 +0200 |
| commit | 5a04796f760a9e4770ccca5006ec5076dec0450c (patch) | |
| tree | ca5e1aa5ae10269dc862656f8bd77e55b7d8a94c /win32 | |
| parent | 536c02b0038ab3fd2d0ef9c2ec3dfe4565ef1b31 (diff) | |
| download | php-git-5a04796f760a9e4770ccca5006ec5076dec0450c.tar.gz | |
Fix MSVC level 1 (severe) warnings
We fix (hopefully) all instances of:
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4005>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4024>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4028>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4047>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4087>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4090>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4273>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4312>
`zend_llist_add_element()` and `zend_llist_prepend_element()` now
explicitly expect a *const* pointer.
We use the macro `ZEND_VOIDP()` instead of a `(void*)` cast to suppress
C4090; this should prevent accidential removal of the cast by
clarifying the intention, and makes it easier to remove the casts if
the issue[1] will be resolved sometime.
[1] <https://developercommunity.visualstudio.com/content/problem/390711/c-compiler-incorrect-propagation-of-const-qualifie.html>
Diffstat (limited to 'win32')
| -rw-r--r-- | win32/winutil.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/win32/winutil.c b/win32/winutil.c index a886964bf0..40664a9e03 100644 --- a/win32/winutil.c +++ b/win32/winutil.c @@ -439,7 +439,7 @@ PHP_WINUTIL_API char *php_win32_get_username(void) static zend_always_inline BOOL is_compatible(const char *name, BOOL is_smaller, char *format, char **err) {/*{{{*/ /* work around ImageLoad() issue */ - char *name_stripped = name; + const char *name_stripped = name; if (name[0] == '.' && IS_SLASH(name[1])) { name_stripped += 2; } |