summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--NEWS2
-rw-r--r--ext/reflection/php_reflection.c2
-rw-r--r--ext/reflection/tests/bug75231.phpt25
3 files changed, 28 insertions, 1 deletions
diff --git a/NEWS b/NEWS
index 5807339087..b1980d5162 100644
--- a/NEWS
+++ b/NEWS
@@ -55,6 +55,8 @@ PHP NEWS
- Reflection:
. Fixed bug #76536 (PHP crashes with core dump when throwing exception in
error handler). (Laruence)
+ . Fixed bug #75231 (ReflectionProperty#getValue() incorrectly works with
+ inherited classes). (Nikita)
- Standard:
. Fixed bug #76505 (array_merge_recursive() is duplicating sub-array keys).
diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
index 144714b47a..7d8ea1c283 100644
--- a/ext/reflection/php_reflection.c
+++ b/ext/reflection/php_reflection.c
@@ -5455,7 +5455,7 @@ ZEND_METHOD(reflection_property, getValue)
return;
}
- if (!instanceof_function(Z_OBJCE_P(object), ref->ce)) {
+ if (!instanceof_function(Z_OBJCE_P(object), ref->prop.ce)) {
_DO_THROW("Given object is not an instance of the class this property was declared in");
/* Returns from this function */
}
diff --git a/ext/reflection/tests/bug75231.phpt b/ext/reflection/tests/bug75231.phpt
new file mode 100644
index 0000000000..5aff0be19c
--- /dev/null
+++ b/ext/reflection/tests/bug75231.phpt
@@ -0,0 +1,25 @@
+--TEST--
+Bug #75231: ReflectionProperty#getValue() incorrectly works with inherited classes
+--FILE--
+<?php
+class A
+{
+ public $prop;
+ public function __construct()
+ {
+ $this->prop = 'prop';
+ }
+ public function method()
+ {
+ return 'method';
+ }
+}
+class B extends A
+{
+}
+print_r((new ReflectionMethod(B::class, 'method'))->invoke(new A()).PHP_EOL);
+print_r((new ReflectionProperty(B::class, 'prop'))->getValue(new A()).PHP_EOL);
+?>
+--EXPECT--
+method
+prop