summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--Zend/tests/restrict_globals/invalid_append.phpt10
-rw-r--r--Zend/zend_compile.c4
2 files changed, 14 insertions, 0 deletions
diff --git a/Zend/tests/restrict_globals/invalid_append.phpt b/Zend/tests/restrict_globals/invalid_append.phpt
new file mode 100644
index 0000000000..8e8b99fb9b
--- /dev/null
+++ b/Zend/tests/restrict_globals/invalid_append.phpt
@@ -0,0 +1,10 @@
+--TEST--
+Cannot append to $GLOBALS
+--FILE--
+<?php
+
+$GLOBALS[] = 1;
+
+?>
+--EXPECTF--
+Fatal error: Cannot append to $GLOBALS in %s on line %d
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
index 58cd190b68..06c0034bc2 100644
--- a/Zend/zend_compile.c
+++ b/Zend/zend_compile.c
@@ -2773,6 +2773,10 @@ static zend_op *zend_delayed_compile_dim(znode *result, zend_ast *ast, uint32_t
znode var_node, dim_node;
if (is_globals_fetch(var_ast)) {
+ if (dim_ast == NULL) {
+ zend_error_noreturn(E_COMPILE_ERROR, "Cannot append to $GLOBALS");
+ }
+
zend_compile_expr(&dim_node, dim_ast);
if (dim_node.op_type == IS_CONST) {
convert_to_string(&dim_node.u.constant);