| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| | |
* PHP-8.0:
Fix #66783: UAF when appending DOMDocument to element
|
| |\
| | |
| | |
| | |
| | | |
* PHP-7.4:
Fix #66783: UAF when appending DOMDocument to element
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
According to the DOM standard, elements may only contain element, text,
processing instruction and comment nodes[1]. It is also specified that
a HierarchyRequestError should be thrown if a document is to be
inserted[2]. We follow that standard, and prevent the use-after-free
this way.
[1] <https://dom.spec.whatwg.org/#node-trees>
[2] <https://dom.spec.whatwg.org/#mutation-algorithms>
Closes GH-6765.
|
| | |
| | |
| | |
| | | |
Closes GH-6780
|
|\ \ \
| |/ / |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
etc.
Now properties are ordered according to their layout in zend_object structure.
|
|\ \ \
| |/ /
| | |
| | |
| | |
| | |
| | | |
* PHP-8.0:
Fix potential file collision in dom tests
Fix bug #80757 (Exit code is 0 when could not open file)
Update NEWS
|
| |\ \
| | |/
| | |
| | |
| | | |
* PHP-7.4:
Fix potential file collision in dom tests
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This deprecates passing null to non-nullable scale arguments of
internal functions, with the eventual goal of making the behavior
consistent with userland functions, where null is never accepted
for non-nullable arguments.
This change is expected to cause quite a lot of fallout. In most
cases, calling code should be adjusted to avoid passing null. In
some cases, PHP should be adjusted to make some function arguments
nullable. I have already fixed a number of functions before landing
this, but feel free to file a bug if you encounter a function that
doesn't accept null, but probably should. (The rule of thumb for
this to be applicable is that the function must have special behavior
for 0 or "", which is distinct from the natural behavior of the
parameter.)
RFC: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg
Closes GH-6475.
|
| |
| |
| |
| |
| |
| | |
According to the DOM specification, this argument should be
nullable. It's also supposed to be a required argument, but
not changing that at this point.
|
| |
| |
| |
| |
| | |
According to the DOM specification, this argument is supposed to
be nullable.
|
| |
| |
| |
| | |
Closes GH-6660
|
|\ \
| |/
| |
| |
| | |
* PHP-7.4:
Fix #80268: loadHTML() truncates at NUL bytes
|
| |\
| | |
| | |
| | |
| | | |
* PHP-7.3:
Fix #80268: loadHTML() truncates at NUL bytes
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
libxml2 has no particular issues parsing HTML strings with NUL bytes;
these just cause truncation of the current text content, but parsing
continues generally. Since `::loadHTMLFile()` already supports NUL
bytes, `::loadHTML()` should as well.
Note that this is different from XML, which does not allow any NUL
bytes.
Closes GH-6368.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Not all extensions consistently throw exceptions when the user passes
a path name containing null bytes. Also, some extensions would throw
a ValueError while others would throw a TypeError. Error messages
also varied.
Now a ValueError is thrown after all failed path checks, at least for
as far as these occur in functions that are exposed to userland.
Closes GH-6216.
|
| | |
| | |
| | |
| | | |
Closes GH-5418
|
| | |
| | |
| | |
| | |
| | | |
This should fix most of the remaining issues with tabs and spaces
being mixed in tests.
|
| | |
| | |
| | |
| | | |
Closes GH-5999
|
| | | |
|
| | |
| | |
| | |
| | | |
Closes GH-5958
|
| | | |
|
| | |
| | |
| | |
| | | |
Closes GH-5590
|
| | |
| | |
| | |
| | |
| | | |
Closes GH-5446
Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
* PHP-7.4:
Revert "Fix #79065: DOM classes do not expose properties to Reflection"
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 6bc8f7e5a9949b2ba79376abd1ed13d0b4d0ae3c.
This causes an assertion failure in PHPUnit.
|
|\ \ \ \
| |/ / /
| | | |
| | | |
| | | | |
* PHP-7.4:
Fix #79065: DOM classes do not expose properties to Reflection
|
| |/ /
| | |
| | |
| | |
| | | |
We add a `get_properties` handler which complements the already
existing `has_property` and `read_property`handlers.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix #78221: DOMNode::normalize() doesn't remove empty text nodes
|
| |\ \
| | |/
| | |
| | |
| | | |
* PHP-7.3:
Fix #78221: DOMNode::normalize() doesn't remove empty text nodes
|
| | |
| | |
| | |
| | |
| | | |
If a text node is not followed by another text node, we remove it, if
its textContent is empty.
|
| | |
| | |
| | |
| | | |
Closes GH-5278
|
| | | |
|
| | | |
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix #79271: DOMDocumentType::$childNodes is NULL
|
| |\ \
| | |/
| | |
| | |
| | | |
* PHP-7.3:
Fix #79271: DOMDocumentType::$childNodes is NULL
|
| | |
| | |
| | |
| | |
| | | |
Dom level 2 core, DOM level 3 core and the DOM living standard agree
that `childNodes` always return a `NodeList`, and never `null`.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix typo in recent bugfix
|
| |\ \
| | |/
| | |
| | |
| | | |
* PHP-7.3:
Fix typo in recent bugfix
|
| | |\
| | | |
| | | |
| | | |
| | | | |
* PHP-7.2:
Fix typo in recent bugfix
|
| | | | |
|
|\ \ \ \
| |/ / /
| | | |
| | | |
| | | | |
* PHP-7.4:
Fix #77569: Write Acess Violation in DomImplementation
|
| |\ \ \
| | |/ /
| | | |
| | | |
| | | | |
* PHP-7.3:
Fix #77569: Write Acess Violation in DomImplementation
|
| | |\ \
| | | |/
| | | |
| | | |
| | | | |
* PHP-7.2:
Fix #77569: Write Acess Violation in DomImplementation
|
| | | |
| | | |
| | | |
| | | | |
We must not assume that the zval IS_STRING.
|
| | | | |
|
| | | | |
|
| | | | |
|