Use gtk_widget_set_visible for everything

gtk_widget_show and gtk_widget_hide are deprecated in GTK 4.10. However,
gtk_widget_set_visible has been around forever so we just need to move to that.

I didn't test all of these and there are probably some that can still be
removed, but most of those are in code that is going to get refreshed in the
future so I didn't bother for now.

Testing Done:
I tested the join chat, add chat, and add buddy dialogs, as well as the contact added notification.

Reviewed at https://reviews.imfreedom.org/r/2430/

20 files changed, 57 insertions, 70 deletions

diff --git a/pidgin/gtkblist.c b/pidgin/gtkblist.c
index 6b60ee85e1..9f286a61f4 100644
--- a/pidgin/gtkblist.c
+++ b/pidgin/gtkblist.c
@@ -439,7 +439,7 @@ pidgin_blist_joinchat_show(void)
 
 	rebuild_chat_entries(data, NULL);
 
-	gtk_widget_show(data->rq_data.window);
+	gtk_widget_set_visible(data->rq_data.window, TRUE);
 }
 
 static void
@@ -451,7 +451,7 @@ pidgin_blist_request_add_buddy(G_GNUC_UNUSED PurpleBuddyList *list,
 
 	dialog = pidgin_add_buddy_dialog_new(account, username, alias, NULL, group);
 
-	gtk_widget_show(dialog);
+	gtk_widget_set_visible(dialog, TRUE);
 }
 
 static void
@@ -463,7 +463,7 @@ pidgin_blist_request_add_chat(G_GNUC_UNUSED PurpleBuddyList *list,
 
 	dialog = pidgin_add_chat_dialog_new(account, group, alias, name);
 
-	gtk_widget_show(dialog);
+	gtk_widget_set_visible(dialog, TRUE);
 }
 
 static void
diff --git a/pidgin/gtkmedia.c b/pidgin/gtkmedia.c
index 4955ab96a1..9630f93564 100644
--- a/pidgin/gtkmedia.c
+++ b/pidgin/gtkmedia.c
@@ -688,7 +688,7 @@ pidgin_media_ready_cb(PurpleMedia *media, PidginMedia *gtkmedia, const gchar *si
 			sink = gst_bin_get_by_name(GST_BIN(pipeline), "gtksink");
 		}
 		g_object_get(G_OBJECT(sink), "widget", &remote_video, NULL);
-		gtk_widget_show(remote_video);
+		gtk_widget_set_visible(remote_video, TRUE);
 		gtk_widget_set_vexpand(remote_video, TRUE);
 		gtk_box_append(GTK_BOX(recv_widget), remote_video);
 
@@ -710,7 +710,7 @@ pidgin_media_ready_cb(PurpleMedia *media, PidginMedia *gtkmedia, const gchar *si
 			sink = gst_bin_get_by_name(GST_BIN(pipeline), "gtksink");
 		}
 		g_object_get(G_OBJECT(sink), "widget", &local_video, NULL);
-		gtk_widget_show(local_video);
+		gtk_widget_set_visible(local_video, TRUE);
 		gtk_widget_set_vexpand(local_video, TRUE);
 		gtk_box_append(GTK_BOX(send_widget), local_video);
 
@@ -819,7 +819,7 @@ pidgin_media_stream_info_cb(G_GNUC_UNUSED PurpleMedia *media,
 		pidgin_media_emit_message(gtkmedia, _("Call in progress."));
 		gtk_statusbar_push(GTK_STATUSBAR(gtkmedia->priv->statusbar),
 				0, _("Call in progress"));
-		gtk_widget_show(GTK_WIDGET(gtkmedia));
+		gtk_widget_set_visible(GTK_WIDGET(gtkmedia), TRUE);
 	} else if (type == PURPLE_MEDIA_INFO_MUTE && !local) {
 		gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(gtkmedia->priv->mute), TRUE);
 	} else if (type == PURPLE_MEDIA_INFO_UNMUTE && !local) {
diff --git a/pidgin/gtknotify.c b/pidgin/gtknotify.c
index 30aa690424..53f5734767 100644
--- a/pidgin/gtknotify.c
+++ b/pidgin/gtknotify.c
@@ -223,7 +223,7 @@ pidgin_notify_message(PurpleNotifyMessageType type, const char *title,
 		purple_request_cpar_get_parent_from(cpar));
 	pidgin_auto_parent_window(dialog);
 
-	gtk_widget_show(dialog);
+	gtk_widget_set_visible(dialog, TRUE);
 
 	return dialog;
 }
@@ -321,7 +321,7 @@ pidgin_notify_formatted(const char *title, const char *primary,
 	/* Show the window */
 	pidgin_auto_parent_window(window);
 
-	gtk_widget_show(window);
+	gtk_widget_set_visible(window, TRUE);
 
 	return window;
 }
@@ -524,7 +524,7 @@ pidgin_notify_searchresults(PurpleConnection *gc, const char *title,
 	/* Show the window */
 	pidgin_auto_parent_window(window);
 
-	gtk_widget_show(window);
+	gtk_widget_set_visible(window, TRUE);
 	return data;
 }
 
diff --git a/pidgin/gtkrequest.c b/pidgin/gtkrequest.c
index 7fabbfc9b1..2829aefe23 100644
--- a/pidgin/gtkrequest.c
+++ b/pidgin/gtkrequest.c
@@ -550,7 +550,7 @@ pidgin_request_input(const char *title, const char *primary,
 	pidgin_auto_parent_window(dialog);
 
 	/* Show everything. */
-	gtk_widget_show(dialog);
+	gtk_widget_set_visible(dialog, TRUE);
 
 	return data;
 }
@@ -683,7 +683,7 @@ pidgin_request_choice(const char *title, const char *primary,
 	/* Show everything. */
 	pidgin_auto_parent_window(dialog);
 
-	gtk_widget_show(dialog);
+	gtk_widget_set_visible(dialog, TRUE);
 
 	return data;
 }
@@ -811,7 +811,7 @@ pidgin_request_action(const char *title, const char *primary,
 	/* Show everything. */
 	pidgin_auto_parent_window(dialog);
 
-	gtk_widget_show(dialog);
+	gtk_widget_set_visible(dialog, TRUE);
 
 	return data;
 }
@@ -929,7 +929,7 @@ pidgin_request_wait(const char *title, const char *primary,
 	/* Show everything. */
 	pidgin_auto_parent_window(dialog);
 
-	gtk_widget_show(dialog);
+	gtk_widget_set_visible(dialog, TRUE);
 
 	return data;
 }
@@ -2002,7 +2002,7 @@ pidgin_request_fields(const char *title, const char *primary,
 
 	pidgin_auto_parent_window(win);
 
-	gtk_widget_show(win);
+	gtk_widget_set_visible(win, TRUE);
 
 	return data;
 }
diff --git a/pidgin/gtkroomlist.c b/pidgin/gtkroomlist.c
index 4c1066bd25..3647c52424 100644
--- a/pidgin/gtkroomlist.c
+++ b/pidgin/gtkroomlist.c
@@ -437,7 +437,7 @@ pidgin_roomlist_dialog_new_with_account(PurpleAccount *account)
 	}
 
 	/* show the dialog window and return the dialog */
-	gtk_widget_show(GTK_WIDGET(dialog));
+	gtk_widget_set_visible(GTK_WIDGET(dialog), TRUE);
 
 	return dialog;
 }
diff --git a/pidgin/gtkwhiteboard.c b/pidgin/gtkwhiteboard.c
index 74fbf9ed5b..366e795629 100644
--- a/pidgin/gtkwhiteboard.c
+++ b/pidgin/gtkwhiteboard.c
@@ -518,7 +518,7 @@ pidgin_whiteboard_create(PurpleWhiteboard *wb)
 	                           &color);
 
 	/* Make all this (window) visible */
-	gtk_widget_show(GTK_WIDGET(gtkwb));
+	gtk_widget_set_visible(GTK_WIDGET(gtkwb), TRUE);
 
 	/* TODO Specific protocol/whiteboard assignment here? Needs a UI Op? */
 	/* Set default brush size and color */
diff --git a/pidgin/gtkxfer.c b/pidgin/gtkxfer.c
index de9d7dae65..56268d0b55 100644
--- a/pidgin/gtkxfer.c
+++ b/pidgin/gtkxfer.c
@@ -311,8 +311,8 @@ update_buttons(PidginXferDialog *dialog, PurpleXfer *xfer)
 		gtk_widget_set_sensitive(dialog->open_button, FALSE);
 		gtk_widget_set_sensitive(dialog->stop_button, FALSE);
 
-		gtk_widget_show(dialog->stop_button);
-		gtk_widget_hide(dialog->remove_button);
+		gtk_widget_set_visible(dialog->stop_button, TRUE);
+		gtk_widget_set_visible(dialog->remove_button, FALSE);
 
 		return;
 	}
@@ -321,8 +321,8 @@ update_buttons(PidginXferDialog *dialog, PurpleXfer *xfer)
 		return;
 
 	if (purple_xfer_is_completed(xfer)) {
-		gtk_widget_hide(dialog->stop_button);
-		gtk_widget_show(dialog->remove_button);
+		gtk_widget_set_visible(dialog->stop_button, FALSE);
+		gtk_widget_set_visible(dialog->remove_button, TRUE);
 
 #ifdef _WIN32
 		/* If using Win32... */
@@ -341,15 +341,15 @@ update_buttons(PidginXferDialog *dialog, PurpleXfer *xfer)
 
 		gtk_widget_set_sensitive(dialog->remove_button, TRUE);
 	} else if (purple_xfer_is_cancelled(xfer)) {
-		gtk_widget_hide(dialog->stop_button);
-		gtk_widget_show(dialog->remove_button);
+		gtk_widget_set_visible(dialog->stop_button, FALSE);
+		gtk_widget_set_visible(dialog->remove_button, TRUE);
 
 		gtk_widget_set_sensitive(dialog->open_button,  FALSE);
 
 		gtk_widget_set_sensitive(dialog->remove_button, TRUE);
 	} else {
-		gtk_widget_show(dialog->stop_button);
-		gtk_widget_hide(dialog->remove_button);
+		gtk_widget_set_visible(dialog->stop_button, TRUE);
+		gtk_widget_set_visible(dialog->remove_button, FALSE);
 
 		gtk_widget_set_sensitive(dialog->open_button,  FALSE);
 		gtk_widget_set_sensitive(dialog->stop_button,   TRUE);
@@ -582,7 +582,7 @@ pidgin_xfer_dialog_show(PidginXferDialog *dialog)
 			pidgin_set_xfer_dialog(tmp);
 		}
 
-		gtk_widget_show(GTK_WIDGET(tmp));
+		gtk_widget_set_visible(GTK_WIDGET(tmp), TRUE);
 	} else {
 		gtk_window_present(GTK_WINDOW(dialog));
 	}
@@ -595,7 +595,7 @@ pidgin_xfer_dialog_hide(PidginXferDialog *dialog)
 
 	purple_notify_close_with_handle(dialog);
 
-	gtk_widget_hide(GTK_WIDGET(dialog));
+	gtk_widget_set_visible(GTK_WIDGET(dialog), FALSE);
 }
 
 void
diff --git a/pidgin/pidgindisplaywindow.c b/pidgin/pidgindisplaywindow.c
index c351c901eb..0c1cebb645 100644
--- a/pidgin/pidgindisplaywindow.c
+++ b/pidgin/pidgindisplaywindow.c
@@ -233,7 +233,7 @@ pidgin_display_window_invite(G_GNUC_UNUSED GSimpleAction *simple,
 			                 NULL);
 		}
 
-		gtk_widget_show(invite_dialog);
+		gtk_widget_set_visible(invite_dialog, TRUE);
 	}
 }
 
diff --git a/pidgin/pidginnotificationaddcontact.c b/pidgin/pidginnotificationaddcontact.c
index 0469d0696b..d3406d4187 100644
--- a/pidgin/pidginnotificationaddcontact.c
+++ b/pidgin/pidginnotificationaddcontact.c
@@ -68,8 +68,8 @@ pidgin_notification_add_contact_update(PidginNotificationAddContact *add_contact
 		gtk_image_set_from_icon_name(GTK_IMAGE(add_contact->icon), NULL);
 		adw_action_row_set_subtitle(ADW_ACTION_ROW(add_contact), NULL);
 
-		gtk_widget_hide(add_contact->add);
-		gtk_widget_hide(add_contact->message);
+		gtk_widget_set_visible(add_contact->add, FALSE);
+		gtk_widget_set_visible(add_contact->message, FALSE);
 
 		return;
 	}
@@ -82,8 +82,8 @@ pidgin_notification_add_contact_update(PidginNotificationAddContact *add_contact
 		gtk_image_set_from_icon_name(GTK_IMAGE(add_contact->icon), NULL);
 		adw_action_row_set_subtitle(ADW_ACTION_ROW(add_contact), NULL);
 
-		gtk_widget_hide(add_contact->add);
-		gtk_widget_hide(add_contact->message);
+		gtk_widget_set_visible(add_contact->add, FALSE);
+		gtk_widget_set_visible(add_contact->message, FALSE);
 
 		return;
 	}
@@ -110,8 +110,8 @@ pidgin_notification_add_contact_update(PidginNotificationAddContact *add_contact
 	message = purple_add_contact_request_get_message(request);
 	adw_action_row_set_subtitle(ADW_ACTION_ROW(add_contact), message);
 
-	gtk_widget_show(add_contact->add);
-	gtk_widget_show(add_contact->message);
+	gtk_widget_set_visible(add_contact->add, TRUE);
+	gtk_widget_set_visible(add_contact->message, TRUE);
 }
 
 static void
diff --git a/pidgin/pidginnotificationauthorizationrequest.c b/pidgin/pidginnotificationauthorizationrequest.c
index eed8d3190f..c4f22b8d87 100644
--- a/pidgin/pidginnotificationauthorizationrequest.c
+++ b/pidgin/pidginnotificationauthorizationrequest.c
@@ -68,9 +68,9 @@ pidgin_notification_authorization_request_update(PidginNotificationAuthorization
 		gtk_image_set_from_icon_name(GTK_IMAGE(request->icon), NULL);
 		adw_action_row_set_subtitle(ADW_ACTION_ROW(request), NULL);
 
-		gtk_widget_hide(request->accept);
-		gtk_widget_hide(request->deny);
-		gtk_widget_hide(request->message);
+		gtk_widget_set_visible(request->accept, FALSE);
+		gtk_widget_set_visible(request->deny, FALSE);
+		gtk_widget_set_visible(request->message, FALSE);
 
 		return;
 	}
@@ -83,9 +83,9 @@ pidgin_notification_authorization_request_update(PidginNotificationAuthorization
 		gtk_image_set_from_icon_name(GTK_IMAGE(request->icon), NULL);
 		adw_action_row_set_subtitle(ADW_ACTION_ROW(request), NULL);
 
-		gtk_widget_hide(request->accept);
-		gtk_widget_hide(request->deny);
-		gtk_widget_hide(request->message);
+		gtk_widget_set_visible(request->accept, FALSE);
+		gtk_widget_set_visible(request->deny, FALSE);
+		gtk_widget_set_visible(request->message, FALSE);
 
 		return;
 	}
@@ -112,9 +112,9 @@ pidgin_notification_authorization_request_update(PidginNotificationAuthorization
 	message = purple_authorization_request_get_message(purple_request);
 	adw_action_row_set_subtitle(ADW_ACTION_ROW(request), message);
 
-	gtk_widget_show(request->accept);
-	gtk_widget_show(request->deny);
-	gtk_widget_show(request->message);
+	gtk_widget_set_visible(request->accept, TRUE);
+	gtk_widget_set_visible(request->deny, TRUE);
+	gtk_widget_set_visible(request->message, TRUE);
 }
 
 static void
diff --git a/pidgin/pidginnotificationconnectionerror.c b/pidgin/pidginnotificationconnectionerror.c
index 57007927d6..acd3300b12 100644
--- a/pidgin/pidginnotificationconnectionerror.c
+++ b/pidgin/pidginnotificationconnectionerror.c
@@ -66,9 +66,9 @@ pidgin_notification_connection_error_update(PidginNotificationConnectionError *e
 		gtk_image_set_from_icon_name(GTK_IMAGE(error->icon), NULL);
 		adw_action_row_set_subtitle(ADW_ACTION_ROW(error), NULL);
 
-		gtk_widget_hide(error->reconnect);
-		gtk_widget_hide(error->reenable);
-		gtk_widget_hide(error->modify);
+		gtk_widget_set_visible(error->reconnect, FALSE);
+		gtk_widget_set_visible(error->reenable, FALSE);
+		gtk_widget_set_visible(error->modify, FALSE);
 
 		return;
 	}
@@ -81,9 +81,9 @@ pidgin_notification_connection_error_update(PidginNotificationConnectionError *e
 		gtk_image_set_from_icon_name(GTK_IMAGE(error->icon), NULL);
 		adw_action_row_set_subtitle(ADW_ACTION_ROW(error), NULL);
 
-		gtk_widget_hide(error->reconnect);
-		gtk_widget_hide(error->reenable);
-		gtk_widget_hide(error->modify);
+		gtk_widget_set_visible(error->reconnect, FALSE);
+		gtk_widget_set_visible(error->reenable, FALSE);
+		gtk_widget_set_visible(error->modify, FALSE);
 
 		return;
 	}
diff --git a/pidgin/pidginstatusmanager.c b/pidgin/pidginstatusmanager.c
index 734554e761..91c9552ab8 100644
--- a/pidgin/pidginstatusmanager.c
+++ b/pidgin/pidginstatusmanager.c
@@ -84,7 +84,7 @@ pidgin_status_manager_show_editor(PidginStatusManager *manager) {
 		                        G_CALLBACK(pidgin_status_editor_destroy_cb),
 		                        manager, 0);
 
-		gtk_widget_show(editor);
+		gtk_widget_set_visible(editor, TRUE);
 	} else {
 		gtk_window_present_with_time(GTK_WINDOW(editor), GDK_CURRENT_TIME);
 	}
@@ -190,7 +190,7 @@ pidgin_status_manager_response_cb(GtkDialog *dialog, gint response_id,
 			editor = pidgin_status_editor_new(NULL);
 			gtk_window_set_transient_for(GTK_WINDOW(editor),
 			                             GTK_WINDOW(manager));
-			gtk_widget_show(editor);
+			gtk_widget_set_visible(editor, TRUE);
 			break;
 		case RESPONSE_MODIFY:
 			pidgin_status_manager_show_editor(manager);
diff --git a/pidgin/plugins/disco/gtkdisco.c b/pidgin/plugins/disco/gtkdisco.c
index 6c3df4f9f6..e81d1a9eb0 100644
--- a/pidgin/plugins/disco/gtkdisco.c
+++ b/pidgin/plugins/disco/gtkdisco.c
@@ -519,7 +519,7 @@ PidginDiscoDialog *
 pidgin_disco_dialog_new(void)
 {
 	PidginDiscoDialog *dialog = g_object_new(PIDGIN_TYPE_DISCO_DIALOG, NULL);
-	gtk_widget_show(GTK_WIDGET(dialog));
+	gtk_widget_set_visible(GTK_WIDGET(dialog), TRUE);
 	return dialog;
 }
 
diff --git a/pidgin/plugins/gestures/gestures.c b/pidgin/plugins/gestures/gestures.c
index 6013c3098b..4bf2170c3f 100644
--- a/pidgin/plugins/gestures/gestures.c
+++ b/pidgin/plugins/gestures/gestures.c
@@ -94,7 +94,7 @@ stroke_new_win(GtkWidget *widget, void *data)
 	                                  conv);
 	pidgin_display_window_add(PIDGIN_DISPLAY_WINDOW(new_win), conv);
 
-	gtk_widget_show_all(new_win);
+	gtk_widget_set_visible(new_win, TRUE);
 }
 
 static void
@@ -185,7 +185,7 @@ get_config_frame(PurplePlugin *plugin)
 	g_signal_connect(G_OBJECT(toggle), "toggled",
 					 G_CALLBACK(toggle_draw_cb), NULL);
 
-	gtk_widget_show_all(ret);
+	gtk_widget_set_visible(ret, TRUE);
 
 	return ret;
 }
diff --git a/pidgin/plugins/gestures/stroke-draw.c b/pidgin/plugins/gestures/stroke-draw.c
index 81e859877a..c66f2cc7cb 100644
--- a/pidgin/plugins/gestures/stroke-draw.c
+++ b/pidgin/plugins/gestures/stroke-draw.c
@@ -233,7 +233,7 @@ gstroke_enable (GtkWidget *widget)
 		                                     GDK_BUTTON_RELEASE_MASK |
 		                                     GDK_BUTTON2_MOTION_MASK);
 		gtk_widget_set_app_paintable(event, TRUE);
-		gtk_widget_show(event);
+		gtk_widget_set_visible(event, TRUE);
 
 		parent = gtk_widget_get_parent(widget);
 		g_object_ref(widget);
diff --git a/pidgin/plugins/notify/notify.c b/pidgin/plugins/notify/notify.c
index ec2025b8ef..efa5aed7ea 100644
--- a/pidgin/plugins/notify/notify.c
+++ b/pidgin/plugins/notify/notify.c
@@ -876,7 +876,7 @@ get_config_frame(PurplePlugin *plugin)
 	                 G_CALLBACK(notify_toggle_cb), "notify_switch");
 #endif
 
-	gtk_widget_show_all(ret);
+	gtk_widget_set_visible(ret, TRUE);
 	return ret;
 }
 
diff --git a/pidgin/plugins/spellchk/spellchk.c b/pidgin/plugins/spellchk/spellchk.c
index 9a1dbf65b9..92b56461eb 100644
--- a/pidgin/plugins/spellchk/spellchk.c
+++ b/pidgin/plugins/spellchk/spellchk.c
@@ -2127,7 +2127,6 @@ get_config_frame(PurplePlugin *plugin)
 
 	vbox = pidgin_make_frame(ret, _("Text Replacements"));
 	gtk_container_set_border_width(GTK_CONTAINER(vbox), 4);
-	gtk_widget_show(vbox);
 
 	tree = gtk_tree_view_new_with_model(GTK_TREE_MODEL(model));
 	gtk_widget_set_size_request(tree, -1, 200);
@@ -2196,7 +2195,6 @@ get_config_frame(PurplePlugin *plugin)
 
 	hbox = gtk_button_box_new(GTK_ORIENTATION_HORIZONTAL);
 	gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 0);
-	gtk_widget_show(hbox);
 
 	button = gtk_button_new_with_mnemonic(_("_Delete"));
 	g_signal_connect(G_OBJECT(button), "clicked",
@@ -2207,16 +2205,12 @@ get_config_frame(PurplePlugin *plugin)
 	g_signal_connect(G_OBJECT(gtk_tree_view_get_selection(GTK_TREE_VIEW(tree))),
 		"changed", G_CALLBACK(on_selection_changed), button);
 
-	gtk_widget_show(button);
-
 	vbox = pidgin_make_frame(ret, _("Add a new text replacement"));
 
 	hbox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 6);
 	gtk_box_pack_start(GTK_BOX(vbox), hbox, TRUE, TRUE, 0);
-	gtk_widget_show(hbox);
 	vbox2 = gtk_box_new(GTK_ORIENTATION_VERTICAL, 6);
 	gtk_box_pack_start(GTK_BOX(hbox), vbox2, TRUE, TRUE, 0);
-	gtk_widget_show(vbox2);
 
 	sg = gtk_size_group_new(GTK_SIZE_GROUP_HORIZONTAL);
 	sg2 = gtk_size_group_new(GTK_SIZE_GROUP_HORIZONTAL);
@@ -2238,12 +2232,10 @@ get_config_frame(PurplePlugin *plugin)
 	gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(complete_toggle), TRUE);
 	g_signal_connect(G_OBJECT(complete_toggle), "clicked",
                          G_CALLBACK(whole_words_button_toggled), case_toggle);
-	gtk_widget_show(complete_toggle);
 	gtk_box_pack_start(GTK_BOX(vbox2), complete_toggle, FALSE, FALSE, 0);
 
 	/* The button is created above so it can be passed to whole_words_button_toggled. */
 	gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(case_toggle), FALSE);
-	gtk_widget_show(case_toggle);
 	gtk_box_pack_start(GTK_BOX(vbox2), case_toggle, FALSE, FALSE, 0);
 
 	button = gtk_button_new_with_mnemonic(_("_Add"));
@@ -2251,12 +2243,10 @@ get_config_frame(PurplePlugin *plugin)
 			   G_CALLBACK(list_add_new), NULL);
 	vbox3 = gtk_box_new(GTK_ORIENTATION_VERTICAL, 0);
 	gtk_box_pack_start(GTK_BOX(hbox), vbox3, TRUE, FALSE, 0);
-	gtk_widget_show(vbox3);
 	gtk_box_pack_end(GTK_BOX(vbox3), button, FALSE, FALSE, 0);
 	g_signal_connect(G_OBJECT(bad_entry), "changed", G_CALLBACK(on_entry_changed), button);
 	g_signal_connect(G_OBJECT(good_entry), "changed", G_CALLBACK(on_entry_changed), button);
 	gtk_widget_set_sensitive(button, FALSE);
-	gtk_widget_show(button);
 
 #if 0
 	vbox = pidgin_make_frame(ret, _("General Text Replacement Options"));
@@ -2264,7 +2254,6 @@ get_config_frame(PurplePlugin *plugin)
 	                        "/plugins/gtk/spellchk/last_word_replace", vbox);
 #endif
 
-	gtk_widget_show_all(ret);
 	g_object_unref(sg);
 	g_object_unref(sg2);
 	return ret;
diff --git a/pidgin/plugins/xmppconsole/xmppconsole.c b/pidgin/plugins/xmppconsole/xmppconsole.c
index adecf6eb14..7c6cdf9fa7 100644
--- a/pidgin/plugins/xmppconsole/xmppconsole.c
+++ b/pidgin/plugins/xmppconsole/xmppconsole.c
@@ -598,8 +598,6 @@ pidgin_xmpp_console_init(PidginXmppConsole *console) {
 
 	dropdown_changed_cb(G_OBJECT(console->account_chooser), NULL, console);
 	entry_changed_cb(console->entry_buffer, console);
-
-	gtk_widget_show(GTK_WIDGET(console));
 }
 
 /******************************************************************************
diff --git a/pidgin/prefs/pidginconversationprefs.c b/pidgin/prefs/pidginconversationprefs.c
index 412e67c165..24a009d608 100644
--- a/pidgin/prefs/pidginconversationprefs.c
+++ b/pidgin/prefs/pidginconversationprefs.c
@@ -92,7 +92,7 @@ pidgin_conversation_prefs_init(PidginConversationPrefs *prefs)
 	pidgin_prefs_bind_switch(PIDGIN_PREFS_ROOT "/win32/blink_im",
 	                         prefs->win32.blink_im);
 #else
-	gtk_widget_hide(prefs->win32.blink_im_row);
+	gtk_widget_set_visible(prefs->win32.blink_im_row, FALSE);
 #endif
 
 	pidgin_prefs_bind_spin_button(
diff --git a/pidgin/prefs/pidginvvprefs.c b/pidgin/prefs/pidginvvprefs.c
index d8d7318123..155c6a3153 100644
--- a/pidgin/prefs/pidginvvprefs.c
+++ b/pidgin/prefs/pidginvvprefs.c
@@ -369,7 +369,7 @@ enable_video_test(PidginVVPrefs *prefs)
 
 	sink = g_object_get_data(G_OBJECT(prefs->video.pipeline), "sink");
 	g_object_get(sink, "widget", &video, NULL);
-	gtk_widget_show(video);
+	gtk_widget_set_visible(video, TRUE);
 
 	gtk_widget_set_size_request(prefs->video.frame, 400, 300);
 	gtk_aspect_frame_set_child(GTK_ASPECT_FRAME(prefs->video.frame), video);