diff options
author | Gary Kramlich <grim@reaperworld.com> | 2021-08-23 07:16:01 -0500 |
---|---|---|
committer | Gary Kramlich <grim@reaperworld.com> | 2021-08-23 07:16:01 -0500 |
commit | 6808d3ab315b6ac29195fbf73ae17ea23181386e (patch) | |
tree | 03794427e808f4aae1103c25871781b299b5cb4e /libpurple/accounts.c | |
parent | c2513fabc0090505365d7b67052a4191142063dd (diff) | |
download | pidgin-6808d3ab315b6ac29195fbf73ae17ea23181386e.tar.gz |
Don't error out when trying to remove a password that isn't stored.
Both wincred and secretservice return an error if you try to delete a password
that they don't know about. We don't care about this scenario and just want to
make sure the password is gone, so we changed the expected behavior to be as
such and updated wincred and secret service for the change.
I also fixed the NULL deference which is how I stumbled across the issue in the
first place.
Testing Done:
* Verfied the issue was fixed in secretservice.
* Verfied the issue didn't exist in kwallet.
Reviewed at https://reviews.imfreedom.org/r/901/
Diffstat (limited to 'libpurple/accounts.c')
-rw-r--r-- | libpurple/accounts.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libpurple/accounts.c b/libpurple/accounts.c index b61041efa1..cb98989306 100644 --- a/libpurple/accounts.c +++ b/libpurple/accounts.c @@ -573,7 +573,7 @@ purple_accounts_delete_set(GObject *obj, GAsyncResult *res, gpointer d) { purple_debug_warning("accounts", "Failed to remove password for account %s: %s", purple_account_get_name_for_display(account), - error->message); + (error != NULL) ? error->message : "Unknown error"); g_clear_error(&error); } |