diff options
| author | Mark Doliner <markdoliner@pidgin.im> | 2009-07-14 07:46:24 +0000 |
|---|---|---|
| committer | Mark Doliner <markdoliner@pidgin.im> | 2009-07-14 07:46:24 +0000 |
| commit | 3599f50089ce04480caef91a87e1e00ecde0203d (patch) | |
| tree | 41f1ba6adc0d397a964cca3175b43235e68cda24 /libpurple/protocols/qq | |
| parent | 3186c168775b5ab631e225c3194b335c467a1e29 (diff) | |
| download | pidgin-3599f50089ce04480caef91a87e1e00ecde0203d.tar.gz | |
Update these comments based on Kevin's reply a week ago on the devel
mailing list
Diffstat (limited to 'libpurple/protocols/qq')
| -rw-r--r-- | libpurple/protocols/qq/Makefile.am | 4 | ||||
| -rw-r--r-- | libpurple/protocols/qq/buddy_info.c | 19 |
2 files changed, 16 insertions, 7 deletions
diff --git a/libpurple/protocols/qq/Makefile.am b/libpurple/protocols/qq/Makefile.am index 66121c0f76..52d3e66c1b 100644 --- a/libpurple/protocols/qq/Makefile.am +++ b/libpurple/protocols/qq/Makefile.am @@ -71,6 +71,10 @@ libqq_la_LIBADD = $(GLIB_LIBS) endif +# QQ_BUDDY_ICON_DIR is the path where a bunch of stock icons can be +# places for users to choose from when setting their buddy icon. We +# don't distribute those icons ourselves because of possibly copyright +# concerns, but distributions might want to put icons here. AM_CPPFLAGS = \ -I$(top_srcdir)/libpurple \ -I$(top_builddir)/libpurple \ diff --git a/libpurple/protocols/qq/buddy_info.c b/libpurple/protocols/qq/buddy_info.c index 40570f55d9..019ac8e41c 100644 --- a/libpurple/protocols/qq/buddy_info.c +++ b/libpurple/protocols/qq/buddy_info.c @@ -531,13 +531,11 @@ gchar *qq_get_icon_name(gint face) } /* - * Hmm, this function is a bit weird. - * 1. The pref "/plugins/prpl/qq/icon_dir" doesn't exist - * 2. QQ_BUDDY_ICON_DIR is set in Makefile.am, but it's set to a - * directory that doesn't exist - * 3. Why would the icon path be different for Windows and Linux? - * 4. Why do we use this in the first place? Setting your icon - * should go through the account editor. + * This function seems to let people set their buddy icon, but it restricts + * them to using a small list of stock icons. Wouldn't it make more sense + * to use libpurple's normal icon setting stuff? + * + * Also it would be nice to unify the icon_dir code for Windows and Linux. */ gchar *qq_get_icon_path(gchar *icon_name) { @@ -551,6 +549,13 @@ gchar *qq_get_icon_path(gchar *icon_name) } #endif + /* + * TODO: The QQ protocol plugin should probably call + * purple_prefs_add_string() at startup to initialize this + * preference. It is used to allow users or distributions + * to specify this directory. We don't include these icons + * with libpurple because of possible copyright concerns. + */ icon_dir = purple_prefs_get_string("/plugins/prpl/qq/icon_dir"); if ( icon_dir == NULL || strlen(icon_dir) == 0) { #ifdef _WIN32 |