pass QString arguments by const reference to avoid unnecessary copying

Testing Done:
compiled and ran pidgin with XMPP accounts that autoconnected

Reviewed at https://reviews.imfreedom.org/r/2341/

2 files changed, 15 insertions, 15 deletions

diff --git a/libpurple/plugins/kwallet/purplekwallet.cpp b/libpurple/plugins/kwallet/purplekwallet.cpp
index 199f9078fd..bce5c0e66d 100644
--- a/libpurple/plugins/kwallet/purplekwallet.cpp
+++ b/libpurple/plugins/kwallet/purplekwallet.cpp
@@ -79,7 +79,7 @@ purple_kwallet_provider_account_key(PurpleAccount *account) {
 /******************************************************************************
  * Request Implementation
  *****************************************************************************/
-PurpleKWalletPlugin::Request::Request(QString key, GTask *task) {
+PurpleKWalletPlugin::Request::Request(const QString &key, GTask *task) {
 	this->key = key;
 	this->task = G_TASK(g_object_ref(G_OBJECT(task)));
 }
@@ -91,7 +91,7 @@ PurpleKWalletPlugin::Request::~Request(void) {
 /******************************************************************************
  * ReadRequest Implementation
  *****************************************************************************/
-PurpleKWalletPlugin::ReadRequest::ReadRequest(QString key, GTask *task) : PurpleKWalletPlugin::Request(key, task) {
+PurpleKWalletPlugin::ReadRequest::ReadRequest(const QString &key, GTask *task) : PurpleKWalletPlugin::Request(key, task) {
 }
 
 void
@@ -128,7 +128,7 @@ PurpleKWalletPlugin::ReadRequest::execute(KWallet::Wallet *wallet) {
 }
 
 void
-PurpleKWalletPlugin::ReadRequest::cancel(QString reason) {
+PurpleKWalletPlugin::ReadRequest::cancel(const QString &reason) {
 	g_task_return_new_error(this->task, PURPLE_KWALLET_DOMAIN, 0,
 	                        _("failed to read password: %s"),
 	                        reason.toUtf8().constData());
@@ -139,7 +139,7 @@ PurpleKWalletPlugin::ReadRequest::cancel(QString reason) {
 /******************************************************************************
  * WriteRequest Implementation
  *****************************************************************************/
-PurpleKWalletPlugin::WriteRequest::WriteRequest(QString key, GTask *task, QString password) : PurpleKWalletPlugin::Request(key, task) {
+PurpleKWalletPlugin::WriteRequest::WriteRequest(const QString &key, GTask *task, const QString &password) : PurpleKWalletPlugin::Request(key, task) {
 	this->password = password;
 }
 
@@ -161,7 +161,7 @@ PurpleKWalletPlugin::WriteRequest::execute(KWallet::Wallet *wallet) {
 }
 
 void
-PurpleKWalletPlugin::WriteRequest::cancel(QString reason) {
+PurpleKWalletPlugin::WriteRequest::cancel(const QString &reason) {
 	g_task_return_new_error(this->task, PURPLE_KWALLET_DOMAIN, 0,
 	                        _("failed to write password: %s"),
 	                        reason.toUtf8().constData());
@@ -172,7 +172,7 @@ PurpleKWalletPlugin::WriteRequest::cancel(QString reason) {
 /******************************************************************************
  * ClearRequest Implementation
  *****************************************************************************/
-PurpleKWalletPlugin::ClearRequest::ClearRequest(QString key, GTask *task) : PurpleKWalletPlugin::Request(key, task) {
+PurpleKWalletPlugin::ClearRequest::ClearRequest(const QString &key, GTask *task) : PurpleKWalletPlugin::Request(key, task) {
 }
 
 void
@@ -193,7 +193,7 @@ PurpleKWalletPlugin::ClearRequest::execute(KWallet::Wallet *wallet) {
 }
 
 void
-PurpleKWalletPlugin::ClearRequest::cancel(QString reason) {
+PurpleKWalletPlugin::ClearRequest::cancel(const QString &reason) {
 	g_task_return_new_error(this->task, PURPLE_KWALLET_DOMAIN, 0,
 	                        _("failed to clear password: %s"),
 	                        reason.toUtf8().constData());
diff --git a/libpurple/plugins/kwallet/purplekwallet.h b/libpurple/plugins/kwallet/purplekwallet.h
index d65d889683..6e13b9f6dd 100644
--- a/libpurple/plugins/kwallet/purplekwallet.h
+++ b/libpurple/plugins/kwallet/purplekwallet.h
@@ -34,10 +34,10 @@ namespace PurpleKWalletPlugin {
 
 class Request {
 public:
-	Request(QString key, GTask *task);
+	Request(const QString &key, GTask *task);
 	virtual ~Request(void);
 	virtual void execute(KWallet::Wallet *wallet) = 0;
-	virtual void cancel(QString reason) = 0;
+	virtual void cancel(const QString &reason) = 0;
 protected:
 	QString key;
 	GTask *task;
@@ -45,25 +45,25 @@ protected:
 
 class ReadRequest : public Request {
 public:
-	ReadRequest(QString key, GTask *task);
+	ReadRequest(const QString &key, GTask *task);
 	void execute(KWallet::Wallet *wallet);
-	void cancel(QString reason);
+	void cancel(const QString &reason);
 };
 
 class WriteRequest : public Request {
 public:
-	WriteRequest(QString key, GTask *task, QString password);
+	WriteRequest(const QString &key, GTask *task, const QString &password);
 	void execute(KWallet::Wallet *wallet);
-	void cancel(QString reason);
+	void cancel(const QString &reason);
 private:
 	QString password;
 };
 
 class ClearRequest : public Request {
 public:
-	ClearRequest(QString key, GTask *task);
+	ClearRequest(const QString &key, GTask *task);
 	void execute(KWallet::Wallet *wallet);
-	void cancel(QString reason);
+	void cancel(const QString &reason);
 };
 
 class Engine : public QObject {