diff options
| author | Gary Kramlich <grim@reaperworld.com> | 2022-04-01 01:14:35 -0500 |
|---|---|---|
| committer | Gary Kramlich <grim@reaperworld.com> | 2022-04-01 01:14:35 -0500 |
| commit | ffd3743f6e81537337ec847213aa6eb0f6bce957 (patch) | |
| tree | f8fb4e896fae223ef239a1f48a5b80b9998c245a /po | |
| parent | 270ecfd676c32c8a6aba90a7d8a11ad7bea4e8b9 (diff) | |
| download | pidgin-ffd3743f6e81537337ec847213aa6eb0f6bce957.tar.gz | |
Add gdk-pixbuf as a libpurple dependency and move helpers from pidgin to purple
Adding gdk-pixbuf as a dependency to libpurple is kind of questionable, but it's dependencies are really just libpng, libjpeg, and libtiff. In other words, nothing UI specific. Which means we can remove a bunch of API with this change which is awesome.
This is the first step in replacing `PurpleImage` with `GdkPixbuf`. Which will also eventually include `PurpleBuddyIcon` and remove the need for `PurpleBuddyIconSpec` as protocol plugins will just be able to scale and format images themselves.
* Move `pidgingdkpixbuf.[ch]` to `purplegdkpixbuf.[ch]`
* Renamed all function from `purplegdkpixbuf.[ch]` to be in the purple_gdk_pixbuf namespace
* Removed all unused function from `purplegdkpixbuf.[ch]`
I also did some research on how much disk space adding gdkpixbuf would add.
The base is a base debian container and this is against libpurple2 which is obviously going to be different. But the question was how much additional disk space will be used by adding gdkpixbuf.
```
base: 157680
bitlbee: 216452
bitlbee+gdkpixbuf: 222388
bitlbee-purple *: 363860
bitlbee-purple+gdkpixbuf *: 369796
* --no-install-recommends
```
We can see that for gdkpixbuf will about about 6MB of of disk usage which I would hope would be acceptable when libpurple adds 141MB by itself.
Testing Done:
Ran and verified that an animated buddy icon was still displayed properly in the infopane and the buddy list.
Reviewed at https://reviews.imfreedom.org/r/1224/
Diffstat (limited to 'po')
| -rw-r--r-- | po/POTFILES.in | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/po/POTFILES.in b/po/POTFILES.in index 43d1320f28..46ab452875 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -248,6 +248,7 @@ libpurple/purplecoreuiops.c libpurple/purplecredentialmanager.c libpurple/purplecredentialprovider.c libpurple/purpledebugui.c +libpurple/purplegdkpixbuf.c libpurple/purple-gio.c libpurple/purplehistoryadapter.c libpurple/purplehistorymanager.c @@ -353,7 +354,6 @@ pidgin/pidgincontactlist.c pidgin/pidginconversationwindow.c pidgin/pidgindebug.c pidgin/pidgindialog.c -pidgin/pidgingdkpixbuf.c pidgin/pidginiconname.c pidgin/pidgininactiveaccountsmenu.c pidgin/pidgininfopane.c |