summaryrefslogtreecommitdiff
path: root/finch/gntrequest.c
Commit message (Collapse)AuthorAgeFilesLines
* Clean up Finch preferences pageElliott Sales de Andrade2023-04-031-1/+4
| | | | | | | | | | | | Instead of mixing two strings into a `GList`, use a `PurpleKeyValuePair`. Use struct initializers and `G_N_ELEMENTS`. Rename `lv` to `choices` for clarity. Change from `PurpleRequestFieldList` to `PurpleRequestFieldChoice` as we don't need multiple selection. Testing Done: Opened Finch, opened Preferences, saved them, and exited Finch. Re-opened Prefs and confirmed they were saved and as expected. Reviewed at https://reviews.imfreedom.org/r/2416/
* Use GListModel access to request fields in finchElliott Sales de Andrade2023-03-171-29/+64
| | | | | | | | | Instead of the `GList`-based API. Testing Done: Compiled only. Reviewed at https://reviews.imfreedom.org/r/2353/
* Remove tracking of required fieldsElliott Sales de Andrade2023-03-171-3/+3
| | | | | | | | | | | The field required&filled status is now encapsulated in the valid property due to /r/2351. This means that UIs no longer need to check that all required fields are filled. So the page no longer needs to track required fields either. Testing Done: Compiled and ran `ninja test`. Also opened Request Fields from Demo protocol, removed the required string or entered an invalid email, and confirmed the OK button disabled correctly. Reviewed at https://reviews.imfreedom.org/r/2352/
* Add PurpleRequest{Group,Page}:valid propertiesElliott Sales de Andrade2023-03-161-1/+1
| | | | | | | | | This collects the validity of the fields/groups within the group/page into a single value. Testing Done: Compiled and ran `ninja test`. Reviewed at https://reviews.imfreedom.org/r/2348/
* Convert PurpleRequestFieldList into a GObjectElliott Sales de Andrade2023-03-101-39/+31
| | | | | | | | | | | This also does an `hg cp`, though with all the renaming of the parameter names, maybe that wasn't as useful for tracking the diff. Also could implement `GListModel`, but it takes arbitrary pointers too, so not right now. Testing Done: Compiled, and opened Request Fields from the Demo protocol. Reviewed at https://reviews.imfreedom.org/r/2336/
* Make PurpleRequestFieldChoice into a GObjectElliott Sales de Andrade2023-03-101-10/+10
| | | | | | | | | | | This also does an `hg cp`, though with all the renaming of the parameter names, maybe that wasn't as useful for tracking the diff. I wonder if this should implement `GListModel`, but the values are currently arbitrary pointers, so it won't work right now. Testing Done: Compiled and opened Request Fields from Demo protocol. Reviewed at https://reviews.imfreedom.org/r/2335/
* Make PurpleRequestFieldInt into a GObjectElliott Sales de Andrade2023-03-101-12/+11
| | | | | | | | | | | This also does an `hg cp`, though with all the renaming of the parameter names, maybe that wasn't as useful for tracking the diff. Note, I didn't bother re-indenting some of the blocks, because they'll all eventually be moved when everything is subclassed. Testing Done: Compiled and opened Request Fields from Demo protocol. Reviewed at https://reviews.imfreedom.org/r/2334/
* Make PurpleRequestFieldBool into a GObjectElliott Sales de Andrade2023-03-101-15/+14
| | | | | | | | | | | This also does an `hg cp`, though with all the renaming of the parameter names, maybe that wasn't as useful for tracking the diff. Note, I didn't bother re-indenting some of the blocks, because they'll all eventually be moved when everything is subclassed. Testing Done: Compiled and opened Request Fields from Demo protocol. Reviewed at https://reviews.imfreedom.org/r/2332/
* Add a PurpleRequestFieldString subclassElliott Sales de Andrade2023-03-101-14/+18
| | | | | | | | | | | This also does an `hg cp`, though with all the renaming of the parameter names, maybe that wasn't as useful for tracking the diff. Note, I didn't bother re-indenting some of the blocks, because they'll all eventually be moved when everything is subclassed. Testing Done: Compiled and opened Request Fields from the Demo protocol. Reviewed at https://reviews.imfreedom.org/r/2324/
* Make PurpleRequestFieldAccount into a GObjectElliott Sales de Andrade2023-03-101-14/+20
| | | | | | | | | | | This also does an `hg cp`, though with all the renaming of the parameter names, maybe that wasn't as useful for tracking the diff, and I should just make these new files entirely? Note, I didn't bother re-indenting some of the blocks, because they'll all eventually be moved when everything is subclassed. Testing Done: Compiled, and opened Request Fields from the Demo protocol. Reviewed at https://reviews.imfreedom.org/r/2331/
* Convert PurpleRequestPage into a GObjectElliott Sales de Andrade2023-03-071-27/+21
| | | | | | | | | | | And rename it from `PurpleRequestFields`. Also, implements `GListModel` for the groups, but nothing uses it that way get. Testing Done: Compiled, and opened Request Fields from Demo protocol. Reviewed at https://reviews.imfreedom.org/r/2323/
* Convert PurpleRequestGroup into a GObjectElliott Sales de Andrade2023-03-071-7/+7
| | | | | | | | | | | And go through with the renaming of `PurpleRequestFieldGroup` to `PurpleRequestGroup`. Also, this now implements `GListModel`, but nothing is yet updated to use that. Testing Done: Compiled, and opened Request Fields from Demo protocol. Reviewed at https://reviews.imfreedom.org/r/2322/
* Replace PurpleRequestField UI data with GObject dataElliott Sales de Andrade2023-03-061-36/+31
| | | | | | | Testing Done: Compiled and opened Request Fields from Demo protocol. Reviewed at https://reviews.imfreedom.org/r/2321/
* Fix typo in request field getterElliott Sales de Andrade2023-03-051-1/+1
| | | | | | | | | The setter does not have the extra "field" in the name. Testing Done: Compiled. Reviewed at https://reviews.imfreedom.org/r/2319/
* Mark unused parameters as such for all finchGary Kramlich2023-02-231-25/+31
| | | | | | | Testing Done: Turned the warning level up to 2, compiled, and verified the warnings were gone. Reviewed at https://reviews.imfreedom.org/r/2254/
* Update Finch for the PurpleAccount deprecationsGary Kramlich2022-12-141-1/+2
| | | | | | | Testing Done: Compiled and ran the tests Reviewed at https://reviews.imfreedom.org/r/2132/
* Move PurpleAccountManager to GPtrArray and implement GListModelElliott Sales de Andrade2022-10-281-19/+37
| | | | | | | | | Move `PurpleAccountManager` to `GPtrArray` and implement `GListModel` Testing Done: Compiled and ran `ninja test`. Opened Account Manager and Privacy Dialog to check that account list seemed okay. Reviewed at https://reviews.imfreedom.org/r/1987/
* Remove C99-obsoleted constructsElliott Sales de Andrade2022-10-261-3/+6
| | | | | | | | | See [this development thread for a future Fedora change](https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/CJXKTLXJUPZ4F2C2VQOTNMEA5JAUPMBD/) or [the proposed change page](https://fedoraproject.org/wiki/Changes/PortingToModernC). These may be made stronger errors in GCC 14. Testing Done: Configured with `-Dc_args='-Werror=implicit-int -Werror=implicit-function-declaration -Werror=int-conversion -Werror=strict-prototypes -Werror=old-style-definition'` and compiled. Reviewed at https://reviews.imfreedom.org/r/1974/
* Move all of the UiOps to use struct initializersGary Kramlich2022-09-201-16/+8
| | | | | | | Testing Done: Compiled Reviewed at https://reviews.imfreedom.org/r/1814/
* port finch to the new AccountManager APIGary Kramlich2021-12-121-6/+8
| | | | | | | Testing Done: Compiled Reviewed at https://reviews.imfreedom.org/r/1146/
* Fix typos in FinchElliott Sales de Andrade2021-10-101-1/+1
| | | | | | | | | Ran `codespell -w`, reverted a few false positives, and cleaned up some bits it couldn't decipher. Testing Done: Compile only. Reviewed at https://reviews.imfreedom.org/r/1019/
* Avoid manual handling of icons in request field list itemsArkadiy Illarionov2021-04-051-20/+20
| | | | | | | | | | | * Use `PurpleKeyValuePair` as field list items * Replace `icons` list with `has_icons` flag, thus fixing memleak * Replace `purple_request_field_list_get_icons` with `purple_request_field_list_has_icons` Testing Done: Compile and run. Reviewed at https://reviews.imfreedom.org/r/563/
* Don't allow libraries to include their own global header files.Gary Kramlich2020-11-191-1/+0
| | | | | | | Testing Done: Compiled, ran unit tests, and built the docs Reviewed at https://reviews.imfreedom.org/r/232/
* Fix Finch for the libgnt single header fileGary Kramlich2020-08-151-9/+0
| | | | | | | | | Fix finch for the gnt.h single include header Testing Done: Compiled on linux and ran finch-docs. Reviewed at https://reviews.imfreedom.org/r/70/
* Make sure that internal.h can only be included by libpurple and split out ↵Gary Kramlich2020-05-011-3/+3
| | | | some pieces to purpleprivate.h
* Split PurpleKeyValuePair out to it's own file and try to do some cleanup in ↵Gary Kramlich2020-04-301-2/+2
| | | | the files that need to include it.
* Replace PurpleNamedValue with PurpleKeyValuePairqarkai2019-11-271-4/+4
|
* Add PurpleNamedValue to use in lists instead of consecutive key and value ↵qarkai2019-11-161-18/+8
| | | | elements
* Replace purple_str_has_{prefix,suffix} by g_str_has_{prefix,suffix}.Elliott Sales de Andrade2019-11-041-2/+2
|
* Use g_(v)snprintf so we need less wrappers.Elliott Sales de Andrade2019-10-301-1/+1
|
* Clean up all of the license headersGary Kramlich2019-09-291-1/+3
|
* A few random finch doc cleanupsGary Kramlich2019-09-281-1/+1
|
* Rename some buddy list accessor functions.Elliott Sales de Andrade2019-07-021-3/+3
| | | | | | | * `purple_blist_get_buddy_list` moved to `purple_blist_get_default` * `purple_blist_get_root` copied to `purple_blist_get_default_root` * `purple_blist_get_root` takes a list argument now
* Use the new gnt_combo_box_get_dropdown.Elliott Sales de Andrade2019-04-231-1/+2
|
* Use new GntFileSel signals.Elliott Sales de Andrade2019-04-231-12/+14
|
* Use gnt_widget_get_toplevel everywhere.Elliott Sales de Andrade2019-04-231-14/+10
|
* gntrequest: Drop certificate request typeMike Ruprecht2018-05-301-25/+0
| | | | | | | | | | | | glib-networking >= 2.57.1 uses system certificates by default. Servers *should* have a proper certificate, and people with self-signed ones *should* be able to add them to their system. Being that exceptions to this are extreme edge cases, it *should* be fine to just use the system certificate store and not worry about trying to manage certificate trust ourselves. If it turns out this is needed, we can always add support later, potentially via a plugin. To that end, this patch drops Finch's certificate request type.
* Merge release-2.x.y into defaultdx2017-06-121-1/+1
|\
| * Remove redundant NULL checksqarkai2017-03-241-1/+1
| | | | | | | | | | If one of purple_strequal() operands is non-NULL, there is no need to check if other is NULL.
| * Replace !strcmp() with purple_strequal()qarkai2017-03-231-1/+1
| | | | | | | | Didn't touch finch/libgnt files
| * Remove -Wno-sign-compare and backport fixes from default.Elliott Sales de Andrade2014-11-131-2/+2
| |
* | Move Tls Certificate parsing code into tls-certificate-info.[ch]Mike Ruprecht2016-04-071-1/+1
| | | | | | | | | | | | This patch moves the TLS certificate parsing code into a new file, separate from the TLS trust and storage code (tls-certificate.[ch]) upon Masca's suggestion.
* | Port Finch to use TLS Certificate APIMike Ruprecht2016-03-301-2/+7
| | | | | | | | | | | | | | | | This patch ports Finch to use the new, simpler certificate API. However, with it, the certificate manager no longer updates if any certificates are added to the certificate directory in the purple config, while it's open. GFileMonitor could be used to replicate this capability if desired.
* | Merge release-2.x.yTomasz Wasilczyk2014-05-071-2/+5
|\ \ | |/
| * Fix some CWE-252 coverity warningsTomasz Wasilczyk2014-05-061-2/+5
| |
* | Finch-OTR: implement missing PurpleRequestCommonParameters featuresTomasz Wasilczyk2014-04-261-0/+44
| |
* | Merged default branchAnkit Vani2014-02-061-7/+8
|\ \
| * | gtk-doc prep: *_get_type() functions are hidden as standard GType-returning ↵Ankit Vani2014-02-061-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | funcs, so rename them. - purple_savedstatus_[gs]et_type renamed to purple_savedstatus_[gs]et_primitive_type - purple_account_option_get_type renamed to purple_account_option_get_pref_type - purple_srv_txt_query_get_type renamed to purple_srv_txt_query_get_query_type - purple_notify_user_info_entry_[gs]et_type renamed to purple_notify_user_info_entry_[gs]et_entry_type - purple_plugin_pref_[gs]et_type renamed to purple_plugin_pref_[gs]et_pref_type - purple_prefs_get_type renamed to purple_prefs_get_pref_type - purple_proxy_info_[gs]et_type renamed to purple_proxy_info_[gs]et_proxy_type - purple_request_field_get_type renamed to purple_request_field_get_field_type - purple_savedstatus_substatus_get_type renamed to purple_savedstatus_substatus_get_status_type
* | | Fix a bunch of gtk-doc warnings in finchAnkit Vani2014-02-041-7/+8
| | |
* | | Remove @file from .c filesAnkit Vani2014-02-041-5/+0
|/ /
View Lorry Controller Status