summaryrefslogtreecommitdiff
path: root/libpurple/prefs.c
Commit message (Collapse)AuthorAgeFilesLines
* Fix leaked errorsElliott Sales de Andrade2023-03-231-3/+1
| | | | | | | | | And also simplify some cases with `g_clear_error`. Testing Done: Compiled and ran tests in valgrind, though it never noticed these anyway. Reviewed at https://reviews.imfreedom.org/r/2384/
* Use g_clear_handle_id everywhereElliott Sales de Andrade2023-03-211-3/+2
| | | | | | | Testing Done: Compiled and ran tests in valgrind. Reviewed at https://reviews.imfreedom.org/r/2374/
* Use g_clear_* helpers where usefulElliott Sales de Andrade2023-03-211-4/+2
| | | | | | | | | | | | | That is: * when the variable is set to `NULL` right after freeing * when the variable is checked for non-`NULL` before freeing * when the variable is a global (because they should be set to `NULL`, even if we don't really claim that things can be re-init'd) Testing Done: Compiled, and ran tests in valgrind. Reviewed at https://reviews.imfreedom.org/r/2369/
* Bump C standard to C99 for libpurple files and fix warningsElliott Sales de Andrade2022-12-111-19/+24
| | | | | | | Testing Done: Touched all source files and compiled; saw no new warnings. Reviewed at https://reviews.imfreedom.org/r/2122/
* Fix libpurple compile on WindowsElliott Sales de Andrade2022-11-031-0/+3
| | | | | | | | | Don't know about Pidgin yet. Testing Done: Compiled on Linux and with mingw cross-compile. Reviewed at https://reviews.imfreedom.org/r/2015/
* Remove C99-obsoleted constructsElliott Sales de Andrade2022-10-261-3/+3
| | | | | | | | | See [this development thread for a future Fedora change](https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/CJXKTLXJUPZ4F2C2VQOTNMEA5JAUPMBD/) or [the proposed change page](https://fedoraproject.org/wiki/Changes/PortingToModernC). These may be made stronger errors in GCC 14. Testing Done: Configured with `-Dc_args='-Werror=implicit-int -Werror=implicit-function-declaration -Werror=int-conversion -Werror=strict-prototypes -Werror=old-style-definition'` and compiled. Reviewed at https://reviews.imfreedom.org/r/1974/
* Remove auto-repliesGary Kramlich2022-09-301-25/+0
| | | | | | | | | | | | Auto-replies only work if the protocol supports them, and at the time of this writing the only protocol that sets that flag is Zephyr which is barely used. Testing Done: Opened the preferences and verified the away page loaded fine. Bugs closed: PIDGIN-17684 Reviewed at https://reviews.imfreedom.org/r/1867/
* Remove PurplePrefsUiOps.Gary Kramlich2022-09-201-256/+8
| | | | | | | | | | | These were added for Instantbird which is no longer maintained and we're moving to GSettings anyways. So this just makes the code easier to understand in the meantime. Testing Done: Compiled Reviewed at https://reviews.imfreedom.org/r/1815/
* Stop including internal.h everywhere when we really don't need it.Gary Kramlich2022-09-121-2/+4
| | | | | | | Testing Done: Compiled, but didn't test on windows. As such I left all the networking stuff untouched as that's where windows will really need it and that can be done in another rr. Reviewed at https://reviews.imfreedom.org/r/1764/
* Prepare GSettings schemas and a default settings backendElliott Sales de Andrade2022-09-111-1/+0
| | | | | | This does nothing by itself yet. Reviewed at https://reviews.imfreedom.org/r/1733/
* Move the path based functions from util.c to their own file.Gary Kramlich2022-01-081-0/+1
| | | | | | | | | | | | This is the first step in cleaning these up and using separate directories for each libpurple based client. Testing Done: Ran with no config directory and added an account. Verified that all of the config files were correctly created. Also ran the unit tests without issue. Reviewed at https://reviews.imfreedom.org/r/1192/
* Only use an info message if we were unable to load the system default ↵Gary Kramlich2021-10-221-1/+1
| | | | | | | | | preferences Testing Done: Ran the debian-bookworm-amd64 container and verified that this fixed the unit tests failing. Reviewed at https://reviews.imfreedom.org/r/1086/
* Use g_list_copy_deep instead of manual copy/transformArkadiy Illarionov2021-02-261-24/+5
| | | | | | | | | It's safe to pass `NULL` as `user_data` if the copy function takes only one argument. Testing Done: Compile and run. Reviewed at https://reviews.imfreedom.org/r/527/
* Remove some old work arounds for coverity.Gary Kramlich2021-01-021-3/+0
| | | | | | | Testing Done: Compiled locally. Reviewed at https://reviews.imfreedom.org/r/321/
* remove the old sound apiGary Kramlich2020-08-131-8/+3
| | | | | | | | | | | | | | | | | | Remove all traces of the old sound api from pidgin Remove all traces of the old sound api from finch Remove all references to the old sound api from libpurple Remove the old sound files Update ChangeLog.API for all the removals Testing Done: Compile tested finch. Ran pidgin, verified the preferences window works, the pounce window dies on something talkatu related but that will be addressed separately. Reviewed at https://reviews.imfreedom.org/r/58/
* Make sure that internal.h can only be included by libpurple and split out ↵Gary Kramlich2020-05-011-4/+3
| | | | some pieces to purpleprivate.h
* fix heap-use-after-free in prefs removalFabrice Bellet2019-11-101-0/+3
|
* Re-write remove_prefs to not use recursion.Elliott Sales de Andrade2019-11-051-22/+50
| | | | | | This also fixes the possible use-after-free that scan-build seems to think is there.
* Use g_rename directly instead of rename.Elliott Sales de Andrade2019-10-301-5/+0
| | | | | | This removes the need for extra compatibility macros, and thus hacks to _undo_ the macro too.
* Use GSList functions instead of manual iterationsqarkai2019-10-161-6/+1
|
* Merged in default (pull request #580)Gary Kramlich2019-10-011-8/+4
|\ | | | | | | | | | | Use g_list_free_full instead of g_list_foreach+g_list_free. Approved-by: Gary Kramlich
| * Use g_list_free_full instead of g_list_foreach+g_list_free.Elliott Sales de Andrade2019-10-011-8/+4
| |
* | Fix some static analysis warnings.Elliott Sales de Andrade2019-10-011-1/+0
|/ | | | | Some redundant assignment, missing NULL-check, and missing frees.
* Move more libpurple files to ~/.config.Elliott Sales de Andrade2019-02-151-2/+2
|
* Remove purple_timeout_* function usageMike Ruprecht2017-06-151-2/+2
| | | | | | | | | | | | Now that the purple_timeout_* functions internally just use their GLib equivalents, we can just replace them with the GLib equivalents. This patch replaces purple_timeout_* functions with g_timeout_add{_seconds}() and g_source_remove() functions. There are probably places in this which could use g_timeout_add_full() or g_idle_add{_full}(), but this was a straight replacement to keep the functionality identical for now. Further patches can update to use these instead if desired.
* Fix prefs for stuff that was broken in the mergeGary Kramlich2016-08-191-0/+11
|
* Monster merge everythingGary Kramlich2016-08-191-38/+347
|\
| * Fix PurpleAccountPrefsUiOps build on Windows where we #define rename as ↵Daniel Atallah2016-06-171-0/+5
| | | | | | | | wpurple_rename
| * Implement PurplePrefsUiOps.(dis)connect_callback from instantbirddx2016-06-161-15/+181
| | | | | | | | | | | | | | | | | | | | They were called observers in instantbird, but since that's a mozilla specific term, I made it generic. Most of the code checks if connect_callback is defined to call the functions that implement callback handling for the UI. The main difference is that when the UI overrides the handling of the preferences, find_pref() won't work, and the callbacks have to be stored elsewhere.
| * Add PurplePrefsUiOps API from instantbirddx2016-06-151-24/+164
| | | | | | | | | | | | | | | | | | | | This allows overriding the prefs.xml storage with anything else. The instantbird version had fewer methods, things like add_string_list or rename_boolean_toggle which are rarely used in libpurple and that instantbird just removed from their fork. The add_observer and remove_observer methods are not implemented yet.
* | Merged default branchAnkit Vani2014-05-201-2/+4
|\ \
| * | Imgupload: add use_url_desc prefTomasz Wasilczyk2014-05-191-2/+1
| | |
| * | Fix coverity dead code warningsTomasz Wasilczyk2014-05-171-0/+3
| | |
* | | Merge default branchAnkit Vani2014-04-161-1/+1
|\ \ \ | |/ / |/| |
| * | Merge gtkdoc-conversionAnkit Vani2014-02-061-1/+1
| |\ \
| | * \ Merge default branchAnkit Vani2014-01-211-1/+1
| | |\ \
| | | * | Revert all the migration stuffAnkit Vani2014-01-211-21/+4
| | | | |
| | | * | Migrate old protocol IDs to new if *.xml version < 1.1Ankit Vani2014-01-201-3/+3
| | | | |
| | | * | Log prefs.xml migrationAnkit Vani2014-01-201-1/+4
| | | | |
| | | * | Update versions of XML files to "1.1", and warn if reading from a newer versionAnkit Vani2014-01-201-4/+18
| | | | |
| | | * | Clean up old "/plugins/lopl" prefs as Mark suggestedAnkit Vani2014-01-181-0/+1
| | | | |
| | | * | Re-revert pref renamesAnkit Vani2014-01-181-1/+1
| | | | |
| | | * | No more loader plugins for libpurple, so remove the "/plugins/lopl" base prefAnkit Vani2014-01-181-1/+0
| | | | |
| | | * | Backed out changeset bc6040e3f9c8Ankit Vani2014-01-171-1/+1
| | | | |
| | | * | Revert pref renamesAnkit Vani2014-01-171-1/+1
| | | | |
| | | * | Merged default branchAnkit Vani2014-01-121-15/+5
| | | |\ \
| | | * \ \ Merged soc.2013.gobjectification branchAnkit Vani2013-09-071-27/+27
| | | |\ \ \
| | | * | | | Renamed some prpl stuff to protocol stuff.Ankit Vani2013-09-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Renamed /plugins/prpl prefs to /protocols
* | | | | | | cross-win32: fix libpurple code warnings and errorsTomasz Wasilczyk2014-04-151-4/+0
| | | | | | |
* | | | | | | cross-win32: tidy remaining macros - SSL_CERTIFICATES_DIR, BUILDDIR, CONFDIRTomasz Wasilczyk2014-04-151-1/+1
| | | | | | |
View Lorry Controller Status