summaryrefslogtreecommitdiff
path: root/libpurple/purplerequestgroup.c
Commit message (Collapse)AuthorAgeFilesLines
* Use GPtrArray internally to PurpleRequest{Group,Page}Elliott Sales de Andrade2023-03-201-7/+8
| | | | | | | | | Now that we don't export a `GList`, we can use these arrays internally. Testing Done: Opened Request Fields from Demo protocol, and confirmed all groups/fields were there. Reviewed at https://reviews.imfreedom.org/r/2364/
* Remove unused API from request fieldsElliott Sales de Andrade2023-03-201-29/+0
| | | | | | | | | | | The `GList` API is no longer used, as containers use the `GListModel` interface. Fetching the group-from-field or page-from-group is no longer needed as previous users now process the field along with the group they were already using. Testing Done: Compiled only. Reviewed at https://reviews.imfreedom.org/r/2363/
* Use GListModel API for request fields in libpurpleElliott Sales de Andrade2023-03-191-4/+0
| | | | | | | Testing Done: Compiled only. Reviewed at https://reviews.imfreedom.org/r/2357/
* Remove tracking of required fieldsElliott Sales de Andrade2023-03-171-10/+0
| | | | | | | | | | | The field required&filled status is now encapsulated in the valid property due to /r/2351. This means that UIs no longer need to check that all required fields are filled. So the page no longer needs to track required fields either. Testing Done: Compiled and ran `ninja test`. Also opened Request Fields from Demo protocol, removed the required string or entered an invalid email, and confirmed the OK button disabled correctly. Reviewed at https://reviews.imfreedom.org/r/2352/
* Remove tracking of whether a field is validatableElliott Sales de Andrade2023-03-171-10/+0
| | | | | | | | | | | This is all handled by properties and `notify` signals now. Nothing reads this state any more. Testing Done: Compiled and ran `ninja test`. Reviewed at https://reviews.imfreedom.org/r/2349/
* Add PurpleRequest{Group,Page}:valid propertiesElliott Sales de Andrade2023-03-161-1/+57
| | | | | | | | | This collects the validity of the fields/groups within the group/page into a single value. Testing Done: Compiled and ran `ninja test`. Reviewed at https://reviews.imfreedom.org/r/2348/
* Cleanup request field filesElliott Sales de Andrade2023-03-111-3/+2
| | | | | | | | | | | | | | | | | | A variety of small followups to splitting the request objects into separate files: * Make `PurpleRequestField` into an abstract type and drop the field type enum. * Add request files to GObject introspection. * Replace `purple_debug` with GLib logging. * Remove extra `#include` where possible. * Remove most early `typedef` which were there for `#include` loops. * Put `G_DEFINE_TYPE` in a consistent place. * Add `Since` tags to objects since they are new (but not the functions), and also to all of `PurpleRequestPage`/`PurpleRequestGroup` which were fully renamed. * Use website for GNU reference in license header. * Clean up old entries in `ChangeLog.API`. Testing Done: Compiled, then checked Class Hierarchy in docs and confirmed that the structs were now there. Reviewed at https://reviews.imfreedom.org/r/2342/
* Fix refs in request page/group list model implementationElliott Sales de Andrade2023-03-091-2/+8
| | | | | | | | | I messed this up the first time, but no-one was using it at the time, so it wasn't noticed. Testing Done: Compiled only. Reviewed at https://reviews.imfreedom.org/r/2330/
* Convert PurpleRequestPage into a GObjectElliott Sales de Andrade2023-03-071-13/+11
| | | | | | | | | | | And rename it from `PurpleRequestFields`. Also, implements `GListModel` for the groups, but nothing uses it that way get. Testing Done: Compiled, and opened Request Fields from Demo protocol. Reviewed at https://reviews.imfreedom.org/r/2323/
* Convert PurpleRequestGroup into a GObjectElliott Sales de Andrade2023-03-071-33/+150
| | | | | | | | | | | And go through with the renaming of `PurpleRequestFieldGroup` to `PurpleRequestGroup`. Also, this now implements `GListModel`, but nothing is yet updated to use that. Testing Done: Compiled, and opened Request Fields from Demo protocol. Reviewed at https://reviews.imfreedom.org/r/2322/
* Convert PurpleRequestField into a GObjectElliott Sales de Andrade2023-03-061-3/+2
| | | | | | | | | | | This is just a straight conversion with not much attempt to make things nice. Also, this leaves `PurpleRequestField` as a multi-type object, but derivable, so we can change to a bunch of subclasses after. Testing Done: Compiled and opened Request Fields from Demo protocol. Reviewed at https://reviews.imfreedom.org/r/2320/
* Split PurpleRequestFieldGroup into its own filesElliott Sales de Andrade2023-03-051-0/+131
As before, this uses `hg cp`, so it _looks_ like a bunch of deletion. Again, there's a bit of private API for the cross-struct access, which should go away later. I also dropped 'field' from the file name, as it seems like there's no need to have that there in the final class name. I did not do any other API changes to make this a simpler review. Testing Done: Compiled and opened Request Fields from the Demo. Reviewed at https://reviews.imfreedom.org/r/2316/
View Lorry Controller Status