| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Testing Done:
Compiled and ran tests in valgrind.
Reviewed at https://reviews.imfreedom.org/r/2374/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That is:
* when the variable is set to `NULL` right after freeing
* when the variable is checked for non-`NULL` before freeing
* when the variable is a global (because they should be set to `NULL`, even if we don't really claim that things can be re-init'd)
Testing Done:
Compiled, and ran tests in valgrind.
Reviewed at https://reviews.imfreedom.org/r/2369/
|
|
|
|
|
|
|
| |
Testing Done:
Compiled and ran the unit tests.
Reviewed at https://reviews.imfreedom.org/r/2133/
|
|
|
|
|
|
|
| |
Testing Done:
Touched all source files and compiled; saw no new warnings.
Reviewed at https://reviews.imfreedom.org/r/2122/
|
|
|
|
|
|
|
|
|
| |
See [this development thread for a future Fedora change](https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/CJXKTLXJUPZ4F2C2VQOTNMEA5JAUPMBD/) or [the proposed change page](https://fedoraproject.org/wiki/Changes/PortingToModernC). These may be made stronger errors in GCC 14.
Testing Done:
Configured with `-Dc_args='-Werror=implicit-int -Werror=implicit-function-declaration -Werror=int-conversion -Werror=strict-prototypes -Werror=old-style-definition'` and compiled.
Reviewed at https://reviews.imfreedom.org/r/1974/
|
|
|
|
|
|
|
|
|
| |
Testing Done:
Opened Pidgin and made sure there were no warnings about objects not existing in time for the new signal connections.
Opened XMPP console and saw that the drop down updated when an XMPP account was added/removed.
Reviewed at https://reviews.imfreedom.org/r/1913/
|
|
|
|
|
|
|
| |
Testing Done:
Compiled, but didn't test on windows. As such I left all the networking stuff untouched as that's where windows will really need it and that can be done in another rr.
Reviewed at https://reviews.imfreedom.org/r/1764/
|
|
|
|
|
|
|
| |
Testing Done:
Compiled
Reviewed at https://reviews.imfreedom.org/r/1535/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Subclass GtkBox instead of GtkContainer
* Remove message editing
* Use a GtkComboBox instead of our fake GtkComboBox
* Move to item id's rather than indexes
* Moved new status, and saved status to GActions
* Removed the account and token_account properties. we now show primitives and
saved status
* Removed the ability to delete saved status from the widget
* Use a widget template to construct the ui elements
* Removed the connection detection stuff
Testing Done:
Verified status were updated when used in the saved status manager.
Verified that the new status and saved status actions work.
Verified that the primitive status work.
Verified that the saved statuses work.
Bugs closed: PIDGIN-17591
Reviewed at https://reviews.imfreedom.org/r/1312/
|
|
|
|
|
|
|
|
|
| |
Another straight search-and-replace for 'easy' review.
Testing Done:
Compile only.
Reviewed at https://reviews.imfreedom.org/r/1371/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces most of the purple_accounts_ API, but not quite everything. The
functions that have been replaced have been marked as deprecated and libpurple
has been updated to use the new API.
Testing Done:
* Connected an XMPP account
* Verified chat and ims worked
* Verified that the saved statuses window didn't crash
* Ran the new unit tests.
Reviewed at https://reviews.imfreedom.org/r/1137/
|
|
|
|
|
|
|
| |
Testing Done:
Sent ims in both pidgin3 and finch3, also joined a chat in pidgin3 and verified that the preferences window is okay.
Reviewed at https://reviews.imfreedom.org/r/1077/
|
|
|
|
|
|
|
|
|
| |
Ran `codespell -w`, ignoring some stuff, or making things better.
Testing Done:
Compile only.
Reviewed at https://reviews.imfreedom.org/r/1016/
|
|
|
|
|
|
|
|
|
|
|
| |
* Use monotonic time for the last IRC ping.
Not sure why I didn't change this one before.
* Fix formats for printing of `time_t`.
Testing Done:
Compile only.
Reviewed at https://reviews.imfreedom.org/r/299/
|
|
|
|
|
|
|
|
|
| |
was changed just moved it from one file to the other.
Testing Done:
Compile and unit tests.
Reviewed at https://reviews.imfreedom.org/r/171/
|
|
|
|
| |
with the repercussions of that.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the purple_timeout_* functions internally just use their
GLib equivalents, we can just replace them with the GLib equivalents.
This patch replaces purple_timeout_* functions with
g_timeout_add{_seconds}() and g_source_remove() functions.
There are probably places in this which could use g_timeout_add_full()
or g_idle_add{_full}(), but this was a straight replacement to keep
the functionality identical for now. Further patches can update to use
these instead if desired.
|
| |
|
|\ |
|
| |\ |
|
| | |\ |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |\ |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Renamed /plugins/prpl prefs to /protocols
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
funcs, so rename them.
- purple_savedstatus_[gs]et_type renamed to purple_savedstatus_[gs]et_primitive_type
- purple_account_option_get_type renamed to purple_account_option_get_pref_type
- purple_srv_txt_query_get_type renamed to purple_srv_txt_query_get_query_type
- purple_notify_user_info_entry_[gs]et_type renamed to purple_notify_user_info_entry_[gs]et_entry_type
- purple_plugin_pref_[gs]et_type renamed to purple_plugin_pref_[gs]et_pref_type
- purple_prefs_get_type renamed to purple_prefs_get_pref_type
- purple_proxy_info_[gs]et_type renamed to purple_proxy_info_[gs]et_proxy_type
- purple_request_field_get_type renamed to purple_request_field_get_field_type
- purple_savedstatus_substatus_get_type renamed to purple_savedstatus_substatus_get_status_type
|
| |/ /
|/| | |
|
|/ / |
|
|/ |
|
|
|
|
| |
of PurpleValue
|
| |
|
|
|
|
| |
saved status, plugins, status.
|
| |
|
|
|
|
| |
functions.
|
|
|
|
| |
prpl-oscar to prpl-aim and prpl-icq. Fixes #2923
|
| |
|
|
|
|
|
| |
These are all from a user's valgrind log in #pidgin a week or so ago. I
think only the proxy and pounce are legitimate leaks.
|
|
|
|
|
|
|
|
| |
increase the size of some buffers to be able to fit -2^63.
I don't think the snprintf() -> g_snprintf() changes do anything with glibc,
but there's no harm in using the glib function to guarantee NUL termination.
Fixes #8974
|
|
|
|
|
|
|
| |
reporting idle properly until restarting Pidgin. Fixes #2002.
committer: John Bailey <rekkanoryo@rekkanoryo.org>
|
|\
| |
| |
| |
| |
| | |
d24c4a9d28f21eaa47bd76e50ed31053733edcb1)
to branch 'im.pidgin.pidgin' (head b60aeb4ba1b0a2368dfeed19db8cbeb808769d1f)
|