| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes two leaks:
```
10,463 (48 direct, 10,415 indirect) bytes in 1 blocks are definitely lost in loss record 34,138 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x1CA978CF: purple_demo_protocol_get_menu (purpledemoprotocolactions.c:750)
by 0x4D2DB1F: purple_protocol_actions_get_menu (purpleprotocolactions.c:110)
by 0x489F74C: pidgin_accounts_enabled_menu_get_item_links (pidginaccountsenabledmenu.c:279)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
```
and
```
2,051 (144 direct, 1,907 indirect) bytes in 3 blocks are definitely lost in loss record 33,018 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x581E9EE: g_menu_item_new_section (gmenu.c:1256)
by 0x48B465F: pidgin_plugins_menu_get_item_links (pidginpluginsmenu.c:204)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
by 0x5124B78: gtk_menu_tracker_add_items (gtkmenutracker.c:313)
```
Testing Done:
Ran in `valgrind --leak-check=full` and confirmed that the leak was gone.
Reviewed at https://reviews.imfreedom.org/r/2298/
|
| |
|
|
|
|
|
|
|
| |
Bump C standard to C99 for Pidgin files only and fix warnings
Testing Done:
Touched all Pidgin files, compiled and saw no new warnings.
Reviewed at https://reviews.imfreedom.org/r/2103/
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The issue was that G_MENU_ATTRIBUTE_ACTION_NAMESPACE only works if the menu
item is a section. So we create a new menu and add the plugins menu to it in
a section that has the property set and everything works.
Testing Done:
Used the actions from idle maker.
Bugs closed: PIDGIN-17708
Reviewed at https://reviews.imfreedom.org/r/2056/
|
| |
|
|
|
|
|
| |
Testing Done:
Loaded and unloaded idlemaker a few times without issue.
Reviewed at https://reviews.imfreedom.org/r/1530/
|
| |
|
|
|
|
|
|
|
| |
Also ported the idle maker plugin to the new api.
Testing Done:
Made sure all of the actions for the idle maker plugin worked.
Reviewed at https://reviews.imfreedom.org/r/1408/
|
| |
|
|
|
|
|
|
|
| |
supports
Testing Done:
Opened a conversation, as well as the plugins and help dialogs.
Reviewed at https://reviews.imfreedom.org/r/898/
|
| |
|
|
|
|
|
| |
Testing Done:
Compiled and connected an XMPP account.
Reviewed at https://reviews.imfreedom.org/r/870/
|
| |
|
|
|
|
|
| |
Testing Done:
Compiled only.
Reviewed at https://reviews.imfreedom.org/r/786/
|
| |
|
|
|
|
|
| |
Testing Done:
Loaded and unloaded idle maker and notification sound and verified that they were added and removed from the menu without any new warnings.
Reviewed at https://reviews.imfreedom.org/r/682/
|
| |
|
|
|
|
|
| |
Testing Done:
Ran locally and verified the separator works from the `Notitication Sound` plugin under both Arc Darc and Adwaita themes.
Reviewed at https://reviews.imfreedom.org/r/659/
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create a new PidginContactList window and move the application actions to PidginApplication.
Testing Done:
* Verified menus are properly disabled while offline
* Verified menu items that require a protocol with chats enables the chat menu items as well as the room list menu items
* Verified that the menu items can become enabled while the menus are opened
* Verified that the application actions are activatable via dbus
* Verified that the plugin manager action was migrated successfully
* Verified that the account manager action was migrated successfully
Reviewed at https://reviews.imfreedom.org/r/174/
|
| | |
|
| | |
|
| |
|
|
| |
whitespace fixes
|
|
|
loaded/unloaded.
|
