summaryrefslogtreecommitdiff
path: root/setup.py
diff options
context:
space:
mode:
authorJon Dufresne <jon.dufresne@gmail.com>2017-10-17 22:03:07 -0700
committerXavier Fernandez <xav.fernandez@gmail.com>2017-10-18 21:57:02 +0200
commit9b42a2b7deec0a88e551688d1091be777b22042c (patch)
tree42119d4ea192f438beb07596ee952e85847b8dd3 /setup.py
parent66c53519c2629ec784659fba85c5a84c88144663 (diff)
downloadpip-9b42a2b7deec0a88e551688d1091be777b22042c.tar.gz
Fix ResourceWarning generated by setup.py when warnings are enabled
Appears as: ResourceWarning: unclosed file ... Always explicitly close open files. Use context manager to make this easier.
Diffstat (limited to 'setup.py')
-rw-r--r--setup.py3
1 files changed, 2 insertions, 1 deletions
diff --git a/setup.py b/setup.py
index 9111b67b2..5f71e0273 100644
--- a/setup.py
+++ b/setup.py
@@ -12,7 +12,8 @@ here = os.path.abspath(os.path.dirname(__file__))
def read(*parts):
# intentionally *not* adding an encoding option to open, See:
# https://github.com/pypa/virtualenv/issues/201#issuecomment-3145690
- return codecs.open(os.path.join(here, *parts), 'r').read()
+ with codecs.open(os.path.join(here, *parts), 'r') as fp:
+ return fp.read()
def find_version(*file_paths):