diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2022-02-02 23:01:56 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2022-02-02 23:01:56 -0500 |
| commit | 4b0e37faaf5ffe1552a07438323341c6394890da (patch) | |
| tree | c24069feb0ccbda5de592cf292e27cfd07e0e01f /config | |
| parent | 9d179d9c23b9d4cc1a4ffa02e4de79114de064d7 (diff) | |
| download | postgresql-4b0e37faaf5ffe1552a07438323341c6394890da.tar.gz | |
Remove configure's check for rl_completion_append_character.
The comment for PGAC_READLINE_VARIABLES says "Readline versions < 2.1
don't have rl_completion_append_character". It seems certain that such
versions are extinct in the wild, though; for sure there are none in the
buildfarm. Libedit has had this variable for at least twenty years too.
Also, tab-complete.c's behavior without it is quite unfriendly, since
we'll emit a space even when completion fails; but we've had no
complaints about that.
Therefore, let's assume this variable is always there, and drop the
configure check to save a few build cycles.
Discussion: https://postgr.es/m/147685.1643858911@sss.pgh.pa.us
Diffstat (limited to 'config')
| -rw-r--r-- | config/programs.m4 | 22 |
1 files changed, 2 insertions, 20 deletions
diff --git a/config/programs.m4 b/config/programs.m4 index 6a118ece24..e7908d8793 100644 --- a/config/programs.m4 +++ b/config/programs.m4 @@ -211,29 +211,11 @@ fi # PGAC_READLINE_VARIABLES # ----------------------- -# Readline versions < 2.1 don't have rl_completion_append_character, -# and some versions lack rl_completion_suppress_quote. +# Some Readline versions lack rl_completion_suppress_quote. # Libedit lacks rl_filename_quote_characters and rl_filename_quoting_function AC_DEFUN([PGAC_READLINE_VARIABLES], -[AC_CACHE_CHECK([for rl_completion_append_character], pgac_cv_var_rl_completion_append_character, -[AC_LINK_IFELSE([AC_LANG_PROGRAM([#include <stdio.h> -#if defined(HAVE_READLINE_READLINE_H) -#include <readline/readline.h> -#elif defined(HAVE_EDITLINE_READLINE_H) -#include <editline/readline.h> -#elif defined(HAVE_READLINE_H) -#include <readline.h> -#endif -], -[rl_completion_append_character = 'x';])], -[pgac_cv_var_rl_completion_append_character=yes], -[pgac_cv_var_rl_completion_append_character=no])]) -if test x"$pgac_cv_var_rl_completion_append_character" = x"yes"; then -AC_DEFINE(HAVE_RL_COMPLETION_APPEND_CHARACTER, 1, - [Define to 1 if you have the global variable 'rl_completion_append_character'.]) -fi -AC_CACHE_CHECK([for rl_completion_suppress_quote], pgac_cv_var_rl_completion_suppress_quote, +[AC_CACHE_CHECK([for rl_completion_suppress_quote], pgac_cv_var_rl_completion_suppress_quote, [AC_LINK_IFELSE([AC_LANG_PROGRAM([#include <stdio.h> #if defined(HAVE_READLINE_READLINE_H) #include <readline/readline.h> |