summaryrefslogtreecommitdiff
path: root/contrib/amcheck
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2022-10-10 15:16:56 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2022-10-10 15:16:56 -0400
commit235eb4db9879397acb57a5dfd25c18291052068a (patch)
treec9a6a0d1f2d6c1227079964621f7ae9873a563c1 /contrib/amcheck
parent6291b2546ce729aa912fd070628c6b9eb1f84947 (diff)
downloadpostgresql-235eb4db9879397acb57a5dfd25c18291052068a.tar.gz
Simplify our Assert infrastructure a little.
Remove the Trap and TrapMacro macros, which were nearly unused and confusingly had the opposite condition polarity from the otherwise-functionally-equivalent Assert macros. Having done that, it's very hard to justify carrying the errorType argument of ExceptionalCondition, so drop that too, and just let it assume everything's an Assert. This saves about 64K of code space as of current HEAD. Discussion: https://postgr.es/m/3928703.1665345117@sss.pgh.pa.us
Diffstat (limited to 'contrib/amcheck')
-rw-r--r--contrib/amcheck/verify_heapam.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/amcheck/verify_heapam.c b/contrib/amcheck/verify_heapam.c
index d33f33f170..83dc728011 100644
--- a/contrib/amcheck/verify_heapam.c
+++ b/contrib/amcheck/verify_heapam.c
@@ -1319,7 +1319,7 @@ check_tuple_attribute(HeapCheckContext *ctx)
*/
/*
- * Check that VARTAG_SIZE won't hit a TrapMacro on a corrupt va_tag before
+ * Check that VARTAG_SIZE won't hit an Assert on a corrupt va_tag before
* risking a call into att_addlength_pointer
*/
if (VARATT_IS_EXTERNAL(tp + ctx->offset))