Remove support for upgrading extensions from "unpackaged" state.

Andres Freund pointed out that allowing non-superusers to run
"CREATE EXTENSION ... FROM unpackaged" has security risks, since
the unpackaged-to-1.0 scripts don't try to verify that the existing
objects they're modifying are what they expect.  Just attaching such
objects to an extension doesn't seem too dangerous, but some of them
do more than that.

We could have resolved this, perhaps, by still requiring superuser
privilege to use the FROM option.  However, it's fair to ask just what
we're accomplishing by continuing to lug the unpackaged-to-1.0 scripts
forward.  None of them have received any real testing since 9.1 days,
so they may not even work anymore (even assuming that one could still
load the previous "loose" object definitions into a v13 database).
And an installation that's trying to go from pre-9.1 to v13 or later
in one jump is going to have worse compatibility problems than whether
there's a trivial way to convert their contrib modules into extension
style.

Hence, let's just drop both those scripts and the core-code support
for "CREATE EXTENSION ... FROM".

Discussion: https://postgr.es/m/20200213233015.r6rnubcvl4egdh5r@alap3.anarazel.de

2 files changed, 1 insertions, 10 deletions

diff --git a/contrib/dict_xsyn/Makefile b/contrib/dict_xsyn/Makefile
index 8d7dd99da7..b6bcfe6dcf 100644
--- a/contrib/dict_xsyn/Makefile
+++ b/contrib/dict_xsyn/Makefile
@@ -6,7 +6,7 @@ OBJS = \
 	dict_xsyn.o
 
 EXTENSION = dict_xsyn
-DATA = dict_xsyn--1.0.sql dict_xsyn--unpackaged--1.0.sql
+DATA = dict_xsyn--1.0.sql
 DATA_TSEARCH = xsyn_sample.rules
 PGFILEDESC = "dict_xsyn - add-on dictionary template for full-text search"
 
diff --git a/contrib/dict_xsyn/dict_xsyn--unpackaged--1.0.sql b/contrib/dict_xsyn/dict_xsyn--unpackaged--1.0.sql
deleted file mode 100644
index 7533da1902..0000000000
--- a/contrib/dict_xsyn/dict_xsyn--unpackaged--1.0.sql
+++ /dev/null
@@ -1,9 +0,0 @@
-/* contrib/dict_xsyn/dict_xsyn--unpackaged--1.0.sql */
-
--- complain if script is sourced in psql, rather than via CREATE EXTENSION
-\echo Use "CREATE EXTENSION dict_xsyn FROM unpackaged" to load this file. \quit
-
-ALTER EXTENSION dict_xsyn ADD function dxsyn_init(internal);
-ALTER EXTENSION dict_xsyn ADD function dxsyn_lexize(internal,internal,internal,internal);
-ALTER EXTENSION dict_xsyn ADD text search template xsyn_template;
-ALTER EXTENSION dict_xsyn ADD text search dictionary xsyn;