diff options
| author | Bruce Momjian <bruce@momjian.us> | 2002-08-15 02:58:29 +0000 |
|---|---|---|
| committer | Bruce Momjian <bruce@momjian.us> | 2002-08-15 02:58:29 +0000 |
| commit | 66eb8df6a4a04922e34dcb2dc543fe231b94903d (patch) | |
| tree | 784f595e15219b79a7f4d609b174c155a5c310f7 /contrib/pg_dumplo/lo_export.c | |
| parent | 7f4981f4af1700456f98ac3f2b2d84959919ec81 (diff) | |
| download | postgresql-66eb8df6a4a04922e34dcb2dc543fe231b94903d.tar.gz | |
The attached patch changes most of the usages of sprintf() to
snprintf() in contrib/. I didn't touch the places where pointer
arithmatic was being used, or other areas where the fix wasn't
trivial. I would think that few, if any, of the usages of sprintf()
were actually exploitable, but it's probably better to be paranoid...
Neil Conway
Diffstat (limited to 'contrib/pg_dumplo/lo_export.c')
| -rw-r--r-- | contrib/pg_dumplo/lo_export.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/contrib/pg_dumplo/lo_export.c b/contrib/pg_dumplo/lo_export.c index adb216fee2..3e38b56409 100644 --- a/contrib/pg_dumplo/lo_export.c +++ b/contrib/pg_dumplo/lo_export.c @@ -1,7 +1,7 @@ /* ------------------------------------------------------------------------- * pg_dumplo * - * $Header: /cvsroot/pgsql/contrib/pg_dumplo/Attic/lo_export.c,v 1.8 2001/10/25 05:49:19 momjian Exp $ + * $Header: /cvsroot/pgsql/contrib/pg_dumplo/Attic/lo_export.c,v 1.9 2002/08/15 02:58:29 momjian Exp $ * * Karel Zak 1999-2000 * ------------------------------------------------------------------------- @@ -110,8 +110,9 @@ pglo_export(LODumpMaster * pgLO) /* * Query: find the LOs referenced by this column */ - sprintf(Qbuff, "SELECT DISTINCT l.loid FROM \"%s\" x, pg_largeobject l WHERE x.\"%s\" = l.loid", - ll->lo_table, ll->lo_attr); + snprintf(Qbuff, QUERY_BUFSIZ, + "SELECT DISTINCT l.loid FROM \"%s\" x, pg_largeobject l WHERE x.\"%s\" = l.loid", + ll->lo_table, ll->lo_attr); /* puts(Qbuff); */ @@ -140,7 +141,7 @@ pglo_export(LODumpMaster * pgLO) if (pgLO->action != ACTION_SHOW) { - sprintf(path, "%s/%s/%s", pgLO->space, pgLO->db, + snprintf(path, BUFSIZ, "%s/%s/%s", pgLO->space, pgLO->db, ll->lo_table); if (mkdir(path, DIR_UMASK) == -1) @@ -152,7 +153,7 @@ pglo_export(LODumpMaster * pgLO) } } - sprintf(path, "%s/%s/%s/%s", pgLO->space, pgLO->db, + snprintf(path, BUFSIZ, "%s/%s/%s/%s", pgLO->space, pgLO->db, ll->lo_table, ll->lo_attr); if (mkdir(path, DIR_UMASK) == -1) @@ -185,7 +186,7 @@ pglo_export(LODumpMaster * pgLO) continue; } - sprintf(path, "%s/%s/%s/%s/%s", pgLO->space, + snprintf(path, BUFSIZ, "%s/%s/%s/%s/%s", pgLO->space, pgLO->db, ll->lo_table, ll->lo_attr, val); if (lo_export(pgLO->conn, lo, path) < 0) |