diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-02-19 16:59:14 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-02-19 16:59:14 -0500 |
| commit | 70a7732007bc4689f4c7a44e738eb2d892dac1e3 (patch) | |
| tree | ee0e3600986e53e6028658dbe2d1bfad3e1f7606 /contrib/tablefunc | |
| parent | 2f9c46a32b43d72c9384378827ee51fde896807c (diff) | |
| download | postgresql-70a7732007bc4689f4c7a44e738eb2d892dac1e3.tar.gz | |
Remove support for upgrading extensions from "unpackaged" state.
Andres Freund pointed out that allowing non-superusers to run
"CREATE EXTENSION ... FROM unpackaged" has security risks, since
the unpackaged-to-1.0 scripts don't try to verify that the existing
objects they're modifying are what they expect. Just attaching such
objects to an extension doesn't seem too dangerous, but some of them
do more than that.
We could have resolved this, perhaps, by still requiring superuser
privilege to use the FROM option. However, it's fair to ask just what
we're accomplishing by continuing to lug the unpackaged-to-1.0 scripts
forward. None of them have received any real testing since 9.1 days,
so they may not even work anymore (even assuming that one could still
load the previous "loose" object definitions into a v13 database).
And an installation that's trying to go from pre-9.1 to v13 or later
in one jump is going to have worse compatibility problems than whether
there's a trivial way to convert their contrib modules into extension
style.
Hence, let's just drop both those scripts and the core-code support
for "CREATE EXTENSION ... FROM".
Discussion: https://postgr.es/m/20200213233015.r6rnubcvl4egdh5r@alap3.anarazel.de
Diffstat (limited to 'contrib/tablefunc')
| -rw-r--r-- | contrib/tablefunc/Makefile | 2 | ||||
| -rw-r--r-- | contrib/tablefunc/tablefunc--unpackaged--1.0.sql | 19 |
2 files changed, 1 insertions, 20 deletions
diff --git a/contrib/tablefunc/Makefile b/contrib/tablefunc/Makefile index 7150117640..191a3a1d38 100644 --- a/contrib/tablefunc/Makefile +++ b/contrib/tablefunc/Makefile @@ -3,7 +3,7 @@ MODULES = tablefunc EXTENSION = tablefunc -DATA = tablefunc--1.0.sql tablefunc--unpackaged--1.0.sql +DATA = tablefunc--1.0.sql PGFILEDESC = "tablefunc - various functions that return tables" REGRESS = tablefunc diff --git a/contrib/tablefunc/tablefunc--unpackaged--1.0.sql b/contrib/tablefunc/tablefunc--unpackaged--1.0.sql deleted file mode 100644 index f0a276a9c4..0000000000 --- a/contrib/tablefunc/tablefunc--unpackaged--1.0.sql +++ /dev/null @@ -1,19 +0,0 @@ -/* contrib/tablefunc/tablefunc--unpackaged--1.0.sql */ - --- complain if script is sourced in psql, rather than via CREATE EXTENSION -\echo Use "CREATE EXTENSION tablefunc FROM unpackaged" to load this file. \quit - -ALTER EXTENSION tablefunc ADD function normal_rand(integer,double precision,double precision); -ALTER EXTENSION tablefunc ADD function crosstab(text); -ALTER EXTENSION tablefunc ADD type tablefunc_crosstab_2; -ALTER EXTENSION tablefunc ADD type tablefunc_crosstab_3; -ALTER EXTENSION tablefunc ADD type tablefunc_crosstab_4; -ALTER EXTENSION tablefunc ADD function crosstab2(text); -ALTER EXTENSION tablefunc ADD function crosstab3(text); -ALTER EXTENSION tablefunc ADD function crosstab4(text); -ALTER EXTENSION tablefunc ADD function crosstab(text,integer); -ALTER EXTENSION tablefunc ADD function crosstab(text,text); -ALTER EXTENSION tablefunc ADD function connectby(text,text,text,text,integer,text); -ALTER EXTENSION tablefunc ADD function connectby(text,text,text,text,integer); -ALTER EXTENSION tablefunc ADD function connectby(text,text,text,text,text,integer,text); -ALTER EXTENSION tablefunc ADD function connectby(text,text,text,text,text,integer); |