diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2022-09-12 09:38:07 +0200 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2022-09-12 10:01:00 +0200 |
| commit | 57796a0f15f8fd3c908aa885a7ebb8ae47ce9880 (patch) | |
| tree | a17383befe002ee0a41cd6ecf9a480e4ad48c390 /doc/src | |
| parent | 88f488319bac051b874bcec87941217e25e0e126 (diff) | |
| download | postgresql-57796a0f15f8fd3c908aa885a7ebb8ae47ce9880.tar.gz | |
Use float8 datatype for percentiles in pg_walinspect stat functions
pg_walinspect uses datatype double (double precision floating point
number) for WAL stats percentile calculations and expose them via
float4 (single precision floating point number), which an unnecessary
loss of precision and confusing. Even though, it's harmless that way,
let's use float8 (double precision floating-point number) to be in
sync with what pg_walinspect does internally and what it exposes to
the users. This seems to be the pattern used elsewhere in the code.
Reported-by: Peter Eisentraut
Author: Bharath Rupireddy
Reviewed-by: Peter Eisentraut
Discussion: https://www.postgresql.org/message-id/36ee692b-232f-0484-ce94-dc39d82021ad%40enterprisedb.com
Diffstat (limited to 'doc/src')
| -rw-r--r-- | doc/src/sgml/pgwalinspect.sgml | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/doc/src/sgml/pgwalinspect.sgml b/doc/src/sgml/pgwalinspect.sgml index de63a70965..1a1bee7d6a 100644 --- a/doc/src/sgml/pgwalinspect.sgml +++ b/doc/src/sgml/pgwalinspect.sgml @@ -164,13 +164,13 @@ postgres=# select start_lsn, end_lsn, prev_lsn, xid, resource_manager, record_ty per_record boolean DEFAULT false, "resource_manager/record_type" OUT text, count OUT int8, - count_percentage OUT float4, + count_percentage OUT float8, record_length OUT int8, - record_length_percentage OUT float4, + record_length_percentage OUT float8, fpi_length OUT int8, - fpi_length_percentage OUT float4, + fpi_length_percentage OUT float8, combined_size OUT int8, - combined_size_percentage OUT float4) + combined_size_percentage OUT float8) returns setof record </function> </term> @@ -241,13 +241,13 @@ postgres=# select * from pg_get_wal_stats('0/14AFC30', '0/15011D7', true) where per_record boolean DEFAULT false, "resource_manager/record_type" OUT text, count OUT int8, - count_percentage OUT float4, + count_percentage OUT float8, record_length OUT int8, - record_length_percentage OUT float4, + record_length_percentage OUT float8, fpi_length OUT int8, - fpi_length_percentage OUT float4, + fpi_length_percentage OUT float8, combined_size OUT int8, - combined_size_percentage OUT float4) + combined_size_percentage OUT float8) returns setof record </function> </term> |