summaryrefslogtreecommitdiff
path: root/src/Makefile
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2018-04-09 16:42:02 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2018-04-09 16:42:10 -0400
commit3b8f6e75f3c8c6d192621f21624cc8cee04ec3cb (patch)
tree093376b0c64cc5d5d8aa537cd0862734c5214f93 /src/Makefile
parent468abb8f7a69c68341b6fc2797166d1079acb1b1 (diff)
downloadpostgresql-3b8f6e75f3c8c6d192621f21624cc8cee04ec3cb.tar.gz
Fix partial-build problems introduced by having more generated headers.
Commit 372728b0d created some problems for usages like building a subdirectory without having first done "make all" at the top level, or for proceeding directly to "make install" without "make all". The only reasonably clean way to fix this seems to be to force the submake-generated-headers rule to fire in *any* "make all" or "make install" command anywhere in the tree. To avoid lots of redundant work, as well as parallel make jobs possibly clobbering each others' output, we still need to be sure that the rule fires only once in a recursive build. For that, adopt the same MAKELEVEL hack previously used for "temp-install". But try to document it a bit better. The submake-errcodes mechanism previously used in src/port/ and src/common/ is subsumed by this, so we can get rid of those special cases. It was inadequate for src/common/ anyway after the aforesaid commit, and it always risked parallel attempts to build errcodes.h. Discussion: https://postgr.es/m/E1f5FAB-0006LU-MB@gemulon.postgresql.org
Diffstat (limited to 'src/Makefile')
-rw-r--r--src/Makefile5
1 files changed, 0 insertions, 5 deletions
diff --git a/src/Makefile b/src/Makefile
index 0e56399cb9..bcdbd9588a 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -41,11 +41,6 @@ endif
$(recurse)
-# Update the commonly used headers before building the subdirectories;
-# otherwise, in a parallel build, several different sub-jobs will try to
-# remake them concurrently
-$(SUBDIRS:%=all-%-recurse): | submake-generated-headers
-
install: install-local
install-local: installdirs-local