To: Thomas Lockhart <Thomas.G.Lockhart@jpl.nasa.gov>

Subject: Re: [PATCHES] SET DateStyle patches

On Tue, 22 Apr 1997, Thomas Lockhart wrote:

> Some more patches! These (try to) finish implementing SET variable TO value
> for "DateStyle" (changed the name from simply "date" to be more descriptive).
> This is based on code from Martin and Bruce (?), which was easy to modify.
> The syntax is
>
> SET DateStyle TO 'iso'
> SET DateStyle TO 'postgres'
> SET DateStyle TO 'sql'
> SET DateStyle TO 'european'
> SET DateStyle TO 'noneuropean'
> SET DateStyle TO 'us'         (same as "noneuropean")
> SET DateStyle TO 'default'    (current same as "postgres,us")
>
> ("european" is just compared for the first 4 characters, and "noneuropean"
> is compared for the first 7 to allow less typing).
>
> Multiple arguments are allowed, so SET datestyle TO 'sql,euro' is valid.
>
> My mods also try to implement "SHOW variable" and "RESET variable", but
> that part just core dumps at the moment. I would guess that my errors
> are obvious to someone who knows what they are doing with the parser stuff,
> so if someone (Bruce and/or Martin??) could have it do the right thing
> we will have a more complete set of what we need.
>
> Also, I would like to have a floating point precision global variable to
> implement "SET precision TO 10" and perhaps "SET precision TO 10,2" for
> float8 and float4, but I don't know how to do that for integer types rather
> than strings. If someone is fixing the SHOW and RESET code, perhaps they can
> add some hooks for me to do the floats while they are at it.
>
> I've left some remnants of variable structures in the source code which
> I did not use in the interests of getting something working for v6.1.
> We'll have time to clean things up for the next release...

1 files changed, 18 insertions, 2 deletions

diff --git a/src/backend/tcop/utility.c b/src/backend/tcop/utility.c
index ec4c7c68ae..03fcd111ca 100644
--- a/src/backend/tcop/utility.c
+++ b/src/backend/tcop/utility.c
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/tcop/utility.c,v 1.14 1997/04/02 18:23:34 scrappy Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/tcop/utility.c,v 1.15 1997/04/23 03:17:09 scrappy Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -643,7 +643,23 @@ ProcessUtility(Node *parsetree,
 	{
 	    VariableSetStmt *n = (VariableSetStmt *) parsetree;
 	    SetPGVariable(n->name, n->value);
-	    commandTag = "SET_VARIABLE";
+	    commandTag = "SET VARIABLE";
+	}
+	break;
+      
+    case T_VariableShowStmt:
+	{
+	    VariableSetStmt *n = (VariableSetStmt *) parsetree;
+	    GetPGVariable(n->name);
+	    commandTag = "SHOW VARIABLE";
+	}
+	break;
+      
+    case T_VariableResetStmt:
+	{
+	    VariableSetStmt *n = (VariableSetStmt *) parsetree;
+	    ResetPGVariable(n->name);
+	    commandTag = "RESET VARIABLE";
 	}
 	break;