diff options
| author | Andres Freund <andres@anarazel.de> | 2022-11-21 20:34:17 -0800 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2022-11-21 20:34:17 -0800 |
| commit | 92daeca45df6551dd85f92f7369eaa57a35fb8a9 (patch) | |
| tree | ba02243ae9ee125666ea2aec25e50a95dc0927dd /src/backend/utils/activity | |
| parent | bd82928625e7ebe40eaaa57f3b4d03bae19491de (diff) | |
| download | postgresql-92daeca45df6551dd85f92f7369eaa57a35fb8a9.tar.gz | |
Add wait event for pg_usleep() in perform_spin_delay()
The lwlock wait queue scalability issue fixed in a4adc31f690 was quite hard to
find because of the exponential backoff and because we adjust spins_per_delay
over time within a backend.
To make it easier to find similar issues in the future, add a wait event for
the pg_usleep() in perform_spin_delay(). Showing a wait event while spinning
without sleeping would increase the overhead of spinlocks, which we do not
want.
We may at some later point want to have more granular wait events, but that'd
be a substantial amount of work. This provides at least some insights into
something currently hard to observe.
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com>
https://postgr.es/m/20221120204310.xywrhyxyytsajuuq@awork3.anarazel.de
Diffstat (limited to 'src/backend/utils/activity')
| -rw-r--r-- | src/backend/utils/activity/wait_event.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/backend/utils/activity/wait_event.c b/src/backend/utils/activity/wait_event.c index 92f24a6c9b..b2abd75ddb 100644 --- a/src/backend/utils/activity/wait_event.c +++ b/src/backend/utils/activity/wait_event.c @@ -497,6 +497,9 @@ pgstat_get_wait_timeout(WaitEventTimeout w) case WAIT_EVENT_REGISTER_SYNC_REQUEST: event_name = "RegisterSyncRequest"; break; + case WAIT_EVENT_SPIN_DELAY: + event_name = "SpinDelay"; + break; case WAIT_EVENT_VACUUM_DELAY: event_name = "VacuumDelay"; break; |