diff options
author | Andrew Dunstan <andrew@dunslane.net> | 2021-07-29 05:58:08 -0400 |
---|---|---|
committer | Andrew Dunstan <andrew@dunslane.net> | 2021-07-29 05:58:08 -0400 |
commit | 201a76183e2056c2217129e12d68c25ec9c559c8 (patch) | |
tree | f25c8d8146f9a3970f776e4ac01f63af4f462184 /src/bin/pg_verifybackup | |
parent | dbfe6e4b1766369654e20113b0cab79bd939d544 (diff) | |
download | postgresql-201a76183e2056c2217129e12d68c25ec9c559c8.tar.gz |
Unify PostgresNode's new() and get_new_node() methods
There is only one constructor now for PostgresNode, with the idiomatic
name 'new'. The method is not exported by the class, and must be called
as "PostgresNode->new('name',[args])". All the TAP tests that use
PostgresNode are modified accordingly. Third party scripts will need
adjusting, which is a fairly mechanical process (I just used a sed
script).
Diffstat (limited to 'src/bin/pg_verifybackup')
-rw-r--r-- | src/bin/pg_verifybackup/t/002_algorithm.pl | 2 | ||||
-rw-r--r-- | src/bin/pg_verifybackup/t/003_corruption.pl | 2 | ||||
-rw-r--r-- | src/bin/pg_verifybackup/t/004_options.pl | 2 | ||||
-rw-r--r-- | src/bin/pg_verifybackup/t/006_encoding.pl | 2 | ||||
-rw-r--r-- | src/bin/pg_verifybackup/t/007_wal.pl | 2 |
5 files changed, 5 insertions, 5 deletions
diff --git a/src/bin/pg_verifybackup/t/002_algorithm.pl b/src/bin/pg_verifybackup/t/002_algorithm.pl index c2c4c3176a..7dc1af982a 100644 --- a/src/bin/pg_verifybackup/t/002_algorithm.pl +++ b/src/bin/pg_verifybackup/t/002_algorithm.pl @@ -12,7 +12,7 @@ use PostgresNode; use TestLib; use Test::More tests => 19; -my $primary = get_new_node('primary'); +my $primary = PostgresNode->new('primary'); $primary->init(allows_streaming => 1); $primary->start; diff --git a/src/bin/pg_verifybackup/t/003_corruption.pl b/src/bin/pg_verifybackup/t/003_corruption.pl index 682b3b857e..509390f975 100644 --- a/src/bin/pg_verifybackup/t/003_corruption.pl +++ b/src/bin/pg_verifybackup/t/003_corruption.pl @@ -12,7 +12,7 @@ use PostgresNode; use TestLib; use Test::More tests => 44; -my $primary = get_new_node('primary'); +my $primary = PostgresNode->new('primary'); $primary->init(allows_streaming => 1); $primary->start; diff --git a/src/bin/pg_verifybackup/t/004_options.pl b/src/bin/pg_verifybackup/t/004_options.pl index 3f6e84c221..d4210fd293 100644 --- a/src/bin/pg_verifybackup/t/004_options.pl +++ b/src/bin/pg_verifybackup/t/004_options.pl @@ -13,7 +13,7 @@ use TestLib; use Test::More tests => 25; # Start up the server and take a backup. -my $primary = get_new_node('primary'); +my $primary = PostgresNode->new('primary'); $primary->init(allows_streaming => 1); $primary->start; my $backup_path = $primary->backup_dir . '/test_options'; diff --git a/src/bin/pg_verifybackup/t/006_encoding.pl b/src/bin/pg_verifybackup/t/006_encoding.pl index a821d52a6a..c0667b7f43 100644 --- a/src/bin/pg_verifybackup/t/006_encoding.pl +++ b/src/bin/pg_verifybackup/t/006_encoding.pl @@ -11,7 +11,7 @@ use PostgresNode; use TestLib; use Test::More tests => 5; -my $primary = get_new_node('primary'); +my $primary = PostgresNode->new('primary'); $primary->init(allows_streaming => 1); $primary->start; my $backup_path = $primary->backup_dir . '/test_encoding'; diff --git a/src/bin/pg_verifybackup/t/007_wal.pl b/src/bin/pg_verifybackup/t/007_wal.pl index 28837b8503..adf60fb755 100644 --- a/src/bin/pg_verifybackup/t/007_wal.pl +++ b/src/bin/pg_verifybackup/t/007_wal.pl @@ -13,7 +13,7 @@ use TestLib; use Test::More tests => 7; # Start up the server and take a backup. -my $primary = get_new_node('primary'); +my $primary = PostgresNode->new('primary'); $primary->init(allows_streaming => 1); $primary->start; my $backup_path = $primary->backup_dir . '/test_wal'; |