diff options
author | Peter Eisentraut <peter_e@gmx.net> | 2018-03-22 20:42:25 -0400 |
---|---|---|
committer | Peter Eisentraut <peter_e@gmx.net> | 2018-03-22 20:42:25 -0400 |
commit | 9a95a77d9d5d3003d2d67121f2731b6e5fc37336 (patch) | |
tree | 1f43f5ff016c3ee689c09030000c4a0e8bc25842 /src/include/access/gin.h | |
parent | 2a0faed9d7028e3830998bd6ca900be651274e27 (diff) | |
download | postgresql-9a95a77d9d5d3003d2d67121f2731b6e5fc37336.tar.gz |
Use stdbool.h if suitable
Using the standard bool type provided by C allows some recent compilers
and debuggers to give better diagnostics. Also, some extension code and
third-party headers are increasingly pulling in stdbool.h, so it's
probably saner if everyone uses the same definition.
But PostgreSQL code is not prepared to handle bool of a size other than
1, so we keep our own old definition if we encounter a stdbool.h with a
bool of a different size. (Among current build farm members, this only
applies to old macOS versions on PowerPC.)
To check that the used bool is of the right size, add a static
assertions about size of GinTernaryValue vs bool. This is currently the
only place that assumes that bool and char are of the same size.
Discussion: https://www.postgresql.org/message-id/flat/3a0fe7e1-5ed1-414b-9230-53bbc0ed1f49@2ndquadrant.com
Diffstat (limited to 'src/include/access/gin.h')
-rw-r--r-- | src/include/access/gin.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/include/access/gin.h b/src/include/access/gin.h index 0acdb88241..3d8a130b69 100644 --- a/src/include/access/gin.h +++ b/src/include/access/gin.h @@ -51,8 +51,8 @@ typedef struct GinStatsData /* * A ternary value used by tri-consistent functions. * - * For convenience, this is compatible with booleans. A boolean can be - * safely cast to a GinTernaryValue. + * This must be of the same size as a bool because some code will cast a + * pointer to a bool to a pointer to a GinTernaryValue. */ typedef char GinTernaryValue; |