diff options
| author | Andres Freund <andres@anarazel.de> | 2023-04-24 12:20:52 -0700 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2023-04-24 12:21:02 -0700 |
| commit | 1118cd37eb61e6a2428f457a8b2026a7bb3f801a (patch) | |
| tree | da41a7760d5fa409a97069c7e505e98a5a0bdf4f /src/include | |
| parent | 441ee1677e6b580794c81943a937cd84363672f3 (diff) | |
| download | postgresql-1118cd37eb61e6a2428f457a8b2026a7bb3f801a.tar.gz | |
Remove vacuum_defer_cleanup_age
vacuum_defer_cleanup_age was introduced before hot_standby_feedback and
replication slots existed. It is hard to use reasonably - commonly it will
either be set too low (not preventing recovery conflicts, while still causing
some bloat), or too high (causing a lot of bloat). The alternatives do not
have that issue.
That on its own might not be sufficient reason to remove
vacuum_defer_cleanup_age, but it also complicates computation of xid
horizons. See e.g. the bug fixed in be504a3e974. It also is untested.
This commit removes TransactionIdRetreatSafely(), as there are no users
anymore. There might be potential future users, hence noting that here.
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Justin Pryzby <pryzby@telsasoft.com>
Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/20230317230930.nhsgk3qfk7f4axls@awork3.anarazel.de
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/storage/standby.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/include/storage/standby.h b/src/include/storage/standby.h index 41f4dc372e..e8f5056949 100644 --- a/src/include/storage/standby.h +++ b/src/include/storage/standby.h @@ -21,7 +21,6 @@ #include "storage/standbydefs.h" /* User-settable GUC parameters */ -extern PGDLLIMPORT int vacuum_defer_cleanup_age; extern PGDLLIMPORT int max_standby_archive_delay; extern PGDLLIMPORT int max_standby_streaming_delay; extern PGDLLIMPORT bool log_recovery_conflict_waits; |