diff options
| author | David Rowley <drowley@postgresql.org> | 2023-04-07 12:47:10 +1200 |
|---|---|---|
| committer | David Rowley <drowley@postgresql.org> | 2023-04-07 12:47:10 +1200 |
| commit | ae78cae3be627213528f2e08eb976d6906d754de (patch) | |
| tree | 2a26745127fc1fa06d9890d6406a1280ad523705 /src/test | |
| parent | 00d1e02be24987180115e371abaeb84738257ae2 (diff) | |
| download | postgresql-ae78cae3be627213528f2e08eb976d6906d754de.tar.gz | |
Add --buffer-usage-limit option to vacuumdb
1cbbee033 added BUFFER_USAGE_LIMIT to the VACUUM and ANALYZE commands, so
here we permit that option to be specified in vacuumdb.
In passing, adjust the documents for vacuum_buffer_usage_limit and the
BUFFER_USAGE_LIMIT VACUUM option to mention "kB" rather than "KB". Do the
same for the ERROR message in ExecVacuum() and
check_vacuum_buffer_usage_limit(). Without that we might tell a user that
the valid minimum value is 128 KB only to reject that because we accept
only "kB" and not "KB".
Also, add a small reminder comment in vacuum.h to try to trigger the
memory of anyone adding new fields to VacuumParams that they might want to
consider if vacuumdb needs to grow a new option too.
Author: Melanie Plageman
Reviewed-by: Justin Pryzby
Reviewed-by: David Rowley
Discussion: https://postgr.es/m/ZAzTg3iEnubscvbf@telsasoft.com
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/regress/expected/vacuum.out | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/test/regress/expected/vacuum.out b/src/test/regress/expected/vacuum.out index eae2743788..044b761024 100644 --- a/src/test/regress/expected/vacuum.out +++ b/src/test/regress/expected/vacuum.out @@ -358,10 +358,10 @@ VACUUM (BUFFER_USAGE_LIMIT 0) vac_option_tab; ANALYZE (BUFFER_USAGE_LIMIT 0) vac_option_tab; -- value exceeds max size error VACUUM (BUFFER_USAGE_LIMIT 16777220) vac_option_tab; -ERROR: buffer_usage_limit option must be 0 or between 128 KB and 16777216 KB +ERROR: buffer_usage_limit option must be 0 or between 128 kB and 16777216 kB -- value is less than min size error VACUUM (BUFFER_USAGE_LIMIT 120) vac_option_tab; -ERROR: buffer_usage_limit option must be 0 or between 128 KB and 16777216 KB +ERROR: buffer_usage_limit option must be 0 or between 128 kB and 16777216 kB -- integer overflow error VACUUM (BUFFER_USAGE_LIMIT 10000000000) vac_option_tab; ERROR: value: "10000000000": is invalid for buffer_usage_limit |