diff options
| author | Eivind Næss <eivnaes@yahoo.com> | 2023-03-16 16:13:25 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-17 10:13:25 +1100 |
| commit | a20059a09c56555f6c2006a7193de4c1676b477a (patch) | |
| tree | 59dbb2eae2f1b52abdf63db82390cb2a6a4678be /pppd/eap.c | |
| parent | 5c9f2d0e37f7b761e7d966385028f32cb0cca0cf (diff) | |
| download | ppp-a20059a09c56555f6c2006a7193de4c1676b477a.tar.gz | |
Fix several issues uncovered by Coverity (#397)
* Fix for coverity issue 436265, we should cap copy to size of destination buffer
Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fix for coverity issue 436262, llv6_ntoa() returns a pointer to a buffer that can be up to 64 bytes long; likely not a problem, but this will quiet coverity
Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fix for coverity issue 436251, not freeing path in the normal flow of the code
Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fixing coverity issue #436258, Digest maybe uninitialized in some paths of this code
Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fix for coverity issue 436254, forgot to free 's' before returning from the function?
Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fixing coverity issue #436251, memory leak in put_string() function
Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fixing coverity issue 436215, should copy at most sizeof(devname) bytes
Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fixing coverity issue #436203, if no authentication (or no accounting) server was found, we still need to free the allocated local instance
Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fixing coverity issue #436171, use of uninitialized variable
Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Use of signed vs unsigned variable in printf for MD4Update
Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fixing coverity issue #436182, fixing possible buffer overrun in handling of PW_CLASS attribute
Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fixing coverity issue #436156
Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Compile errors
Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
[paulus@ozlabs.org - Squashed to avoid breaking bisection]
Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
Diffstat (limited to 'pppd/eap.c')
| -rw-r--r-- | pppd/eap.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -2654,7 +2654,7 @@ eap_response(eap_state *esp, u_char *inp, int id, int len) char tmp[MAXNAMELEN+1]; strcpy(tmp, strrchr(rhostname, '\\') + 1); - strcpy(rhostname, tmp); + strlcpy(rhostname, tmp, sizeof(rhostname)); } if (chap_verify_hook) |