diff options
author | Paul Mackerras <paulus@ozlabs.org> | 2022-08-04 12:23:08 +1000 |
---|---|---|
committer | Paul Mackerras <paulus@ozlabs.org> | 2022-08-04 12:23:08 +1000 |
commit | a75fb7b198eed50d769c80c36629f38346882cbf (patch) | |
tree | 4c493eaefe99c7dff94e61211e803f9d9854043e /pppd | |
parent | fb3529ccfc1868e8563a2dcfbae7b386125fccbc (diff) | |
download | ppp-a75fb7b198eed50d769c80c36629f38346882cbf.tar.gz |
pppdump: Avoid out-of-range access to packet buffer
This fixes a potential vulnerability where data is written to spkt.buf
and rpkt.buf without a check on the array index. To fix this, we
check the array index (pkt->cnt) before storing the byte or
incrementing the count. This also means we no longer have a potential
signed integer overflow on the increment of pkt->cnt.
Fortunately, pppdump is not used in the normal process of setting up a
PPP connection, is not installed setuid-root, and is not invoked
automatically in any scenario that I am aware of.
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
Diffstat (limited to 'pppd')
0 files changed, 0 insertions, 0 deletions