summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlistair Leslie-Hughes <leslie_alistair@hotmail.com>2022-11-03 09:22:48 +1100
committerPulseAudio Marge Bot <pulseaudio-maintainers@lists.freedesktop.org>2022-11-24 21:58:53 +0000
commite650c2b33e4fefc0589751b3958bd3b5d3b423ac (patch)
tree8d315a5913afbd6fed84946314e5fef3696223eb
parent3349e1c471f16f46251a51acfc1740cdf012a098 (diff)
downloadpulseaudio-e650c2b33e4fefc0589751b3958bd3b5d3b423ac.tar.gz
Ensure fds are closed when exec functions are used.
When usng shm_open, FD_CLOEXEC is set explicitly. However when using memfd_create, we must pass the MFD_CLOEXEC flag to ensure the same fcntl value (FD_CLOEXEC) is set. Fixes #1394 Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/751>
-rw-r--r--src/pulsecore/shm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/pulsecore/shm.c b/src/pulsecore/shm.c
index e464f6bce..ff54dcb59 100644
--- a/src/pulsecore/shm.c
+++ b/src/pulsecore/shm.c
@@ -164,7 +164,7 @@ static int sharedmem_create(pa_shm *m, pa_mem_type_t type, size_t size, mode_t m
#endif
#ifdef HAVE_MEMFD
case PA_MEM_TYPE_SHARED_MEMFD:
- fd = memfd_create("pulseaudio", MFD_ALLOW_SEALING);
+ fd = memfd_create("pulseaudio", MFD_ALLOW_SEALING|MFD_CLOEXEC);
break;
#endif
default: