diff options
author | Christoph Reiter <reiter.christoph@gmail.com> | 2018-03-27 14:40:36 +0200 |
---|---|---|
committer | Christoph Reiter <reiter.christoph@gmail.com> | 2018-03-27 14:40:36 +0200 |
commit | 908d099c600a622f85abe452bd10968fb4a15e3d (patch) | |
tree | 0787419ae3efdc73e1c4464f0aa1981bf2009372 /tests/test_overrides_gtk.py | |
parent | a56ad49211a22342dc1cc2c918cb4782b23212dc (diff) | |
download | pygobject-908d099c600a622f85abe452bd10968fb4a15e3d.tar.gz |
Make Gtk.List/TreeStore.insert_before/after atomic
Instead of adding a row and then setting the values do it in one
go using insert_with_values().
This gets rid of a row-changed signal and things like cellrenderers
don't have to deal with potentially empty rows. It's also a bit faster.
Diffstat (limited to 'tests/test_overrides_gtk.py')
-rw-r--r-- | tests/test_overrides_gtk.py | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/tests/test_overrides_gtk.py b/tests/test_overrides_gtk.py index 526632db..0a1d08fd 100644 --- a/tests/test_overrides_gtk.py +++ b/tests/test_overrides_gtk.py @@ -1404,14 +1404,14 @@ class TestTreeModel(unittest.TestCase): iter_ = store.insert_before(None, [1234]) assert store.get_path(iter_).get_indices() == [3] assert store.get_value(iter_, 0) == 1234 - assert signals == ['row-inserted', 'row-changed'] + assert signals == ['row-inserted'] del signals[:] # insert non-empty iter_ = store.insert_before(iter_, [4321]) assert store.get_path(iter_).get_indices() == [3] assert store.get_value(iter_, 0) == 4321 - assert signals == ['row-inserted', 'row-changed'] + assert signals == ['row-inserted'] del signals[:] assert [r[0] for r in store] == [0, None, None, 4321, 1234] @@ -1452,14 +1452,14 @@ class TestTreeModel(unittest.TestCase): iter_ = store.insert_after(None, [1234]) assert store.get_path(iter_).get_indices() == [0] assert store.get_value(iter_, 0) == 1234 - assert signals == ['row-inserted', 'row-changed'] + assert signals == ['row-inserted'] del signals[:] # insert non-empty iter_ = store.insert_after(iter_, [4321]) assert store.get_path(iter_).get_indices() == [1] assert store.get_value(iter_, 0) == 4321 - assert signals == ['row-inserted', 'row-changed'] + assert signals == ['row-inserted'] del signals[:] assert [r[0] for r in store] == [1234, 4321, None, None, 0] @@ -1505,14 +1505,14 @@ class TestTreeModel(unittest.TestCase): iter_ = store.insert_before(parent, None, [1234]) assert store.get_path(iter_).get_indices() == [0, 3] assert store.get_value(iter_, 0) == 1234 - assert signals == ['row-inserted', 'row-changed'] + assert signals == ['row-inserted'] del signals[:] # insert non-empty iter_ = store.insert_before(parent, iter_, [4321]) assert store.get_path(iter_).get_indices() == [0, 3] assert store.get_value(iter_, 0) == 4321 - assert signals == ['row-inserted', 'row-changed'] + assert signals == ['row-inserted'] del signals[:] def func(model, path, iter_, rows): @@ -1565,14 +1565,14 @@ class TestTreeModel(unittest.TestCase): iter_ = store.insert_after(parent, None, [1234]) assert store.get_path(iter_).get_indices() == [0, 0] assert store.get_value(iter_, 0) == 1234 - assert signals == ['row-inserted', 'row-changed'] + assert signals == ['row-inserted'] del signals[:] # insert non-empty iter_ = store.insert_after(parent, iter_, [4321]) assert store.get_path(iter_).get_indices() == [0, 1] assert store.get_value(iter_, 0) == 4321 - assert signals == ['row-inserted', 'row-changed'] + assert signals == ['row-inserted'] del signals[:] def func(model, path, iter_, rows): |