X509Name: Use functools.totalordering for comparisons (#1086)

* X509Name: Use functools.totalordering for comparisons

- Reduce the magic
- Make it more readable
- Make it easier to add type annotations in the future

* Correctly return NotImplemented

* Add new comparison test case

1 files changed, 13 insertions, 0 deletions

diff --git a/tests/test_crypto.py b/tests/test_crypto.py
index d66e257..ca2a17a 100644
--- a/tests/test_crypto.py
+++ b/tests/test_crypto.py
@@ -1398,6 +1398,19 @@ class TestX509Name:
         # other X509Name.
         assert_greater_than(x509_name(CN="def"), x509_name(CN="abc"))
 
+        def assert_raises(a, b):
+            with pytest.raises(TypeError):
+                a < b
+            with pytest.raises(TypeError):
+                a <= b
+            with pytest.raises(TypeError):
+                a > b
+            with pytest.raises(TypeError):
+                a >= b
+
+        # Only X509Name objects can be compared with lesser than / greater than
+        assert_raises(x509_name(), object())
+
     def test_hash(self):
         """
         `X509Name.hash` returns an integer hash based on the value of the name.