diff options
author | Jean-Paul Calderone <exarkun@twistedmatrix.com> | 2013-08-12 18:05:51 -0400 |
---|---|---|
committer | Jean-Paul Calderone <exarkun@twistedmatrix.com> | 2013-08-12 18:05:51 -0400 |
commit | ff83cddd17d5c4b657a9b1bf32f0ce9c1847001f (patch) | |
tree | 92881f238c90db2facf7579faea9be3b8ad1795c /OpenSSL/crypto | |
parent | b557e98ddba211beca85681eb02b342ea2c064e9 (diff) | |
download | pyopenssl-ff83cddd17d5c4b657a9b1bf32f0ce9c1847001f.tar.gz |
Ghetto rebase Heimes' changes onto the 0.13 release branch
Diffstat (limited to 'OpenSSL/crypto')
-rw-r--r-- | OpenSSL/crypto/x509.c | 1 | ||||
-rw-r--r-- | OpenSSL/crypto/x509ext.c | 78 |
2 files changed, 78 insertions, 1 deletions
diff --git a/OpenSSL/crypto/x509.c b/OpenSSL/crypto/x509.c index 0754dec..c086ce8 100644 --- a/OpenSSL/crypto/x509.c +++ b/OpenSSL/crypto/x509.c @@ -756,6 +756,7 @@ crypto_X509_get_extension(crypto_X509Obj *self, PyObject *args) { extobj = PyObject_New(crypto_X509ExtensionObj, &crypto_X509Extension_Type); extobj->x509_extension = X509_EXTENSION_dup(ext); + extobj->dealloc = 1; return (PyObject*)extobj; } diff --git a/OpenSSL/crypto/x509ext.c b/OpenSSL/crypto/x509ext.c index adbe084..caa78b0 100644 --- a/OpenSSL/crypto/x509ext.c +++ b/OpenSSL/crypto/x509ext.c @@ -236,6 +236,75 @@ crypto_X509Extension_dealloc(crypto_X509ExtensionObj *self) PyObject_Del(self); } + +/* Special handling of subjectAltName, see CVE-2013-4073 */ + +int +crypto_X509Extension_str_san(crypto_X509ExtensionObj *self, BIO *bio) +{ + GENERAL_NAMES *names; + const X509V3_EXT_METHOD *method = NULL; + long i, length, num; + const unsigned char *p; + + method = X509V3_EXT_get(self->x509_extension); + if (method == NULL) { + return -1; + } + + p = self->x509_extension->value->data; + length = self->x509_extension->value->length; + if (method->it) { + names = (GENERAL_NAMES*)(ASN1_item_d2i(NULL, &p, length, + ASN1_ITEM_ptr(method->it))); + } + else { + names = (GENERAL_NAMES*)(method->d2i(NULL, &p, length)); + } + if (names == NULL) { + return -1; + } + + num = sk_GENERAL_NAME_num(names); + for (i = 0; i < num; i++) { + GENERAL_NAME *name; + ASN1_STRING *as; + name = sk_GENERAL_NAME_value(names, i); + switch (name->type) { + case GEN_EMAIL: + BIO_puts(bio, "email:"); + as = name->d.rfc822Name; + BIO_write(bio, ASN1_STRING_data(as), + ASN1_STRING_length(as)); + break; + case GEN_DNS: + BIO_puts(bio, "DNS:"); + as = name->d.dNSName; + BIO_write(bio, ASN1_STRING_data(as), + ASN1_STRING_length(as)); + break; + case GEN_URI: + BIO_puts(bio, "URI:"); + as = name->d.uniformResourceIdentifier; + BIO_write(bio, ASN1_STRING_data(as), + ASN1_STRING_length(as)); + break; + default: + /* use builtin print for GEN_OTHERNAME, GEN_X400, + * GEN_EDIPARTY, GEN_DIRNAME, GEN_IPADD and GEN_RID + */ + GENERAL_NAME_print(bio, name); + } + /* trailing ', ' except for last element */ + if (i < (num - 1)) { + BIO_puts(bio, ", "); + } + } + sk_GENERAL_NAME_pop_free(names, GENERAL_NAME_free); + + return 0; +} + /* * Print a nice text representation of the certificate request. */ @@ -247,7 +316,14 @@ crypto_X509Extension_str(crypto_X509ExtensionObj *self) PyObject *str; BIO *bio = BIO_new(BIO_s_mem()); - if (!X509V3_EXT_print(bio, self->x509_extension, 0, 0)) + if (OBJ_obj2nid(self->x509_extension->object) == NID_subject_alt_name) { + if (crypto_X509Extension_str_san(self, bio) == -1) { + BIO_free(bio); + exception_from_error_queue(crypto_Error); + return NULL; + } + } + else if (!X509V3_EXT_print(bio, self->x509_extension, 0, 0)) { BIO_free(bio); exception_from_error_queue(crypto_Error); |