diff options
| author | Ville Skytt? <ville.skytta@iki.fi> | 2016-07-20 10:15:18 +0300 |
|---|---|---|
| committer | Ville Skytt? <ville.skytta@iki.fi> | 2016-07-20 10:15:18 +0300 |
| commit | 109f1fdb78e6409f83e680ed301c38490dfe2e14 (patch) | |
| tree | 240f4ad2733147e806947c67b11669fd4fb3efa5 | |
| parent | a003fc65c5a0904894bd16fab351a4459348f70e (diff) | |
| download | python-coveragepy-html-filter.tar.gz | |
Speed up HTML filteringhtml-filter
| -rw-r--r-- | coverage/htmlfiles/coverage_html.js | 20 | ||||
| -rw-r--r-- | doc/sample_html/coverage_html.js | 20 |
2 files changed, 18 insertions, 22 deletions
diff --git a/coverage/htmlfiles/coverage_html.js b/coverage/htmlfiles/coverage_html.js index 51904dd..f6f5de2 100644 --- a/coverage/htmlfiles/coverage_html.js +++ b/coverage/htmlfiles/coverage_html.js @@ -73,30 +73,28 @@ coverage.wire_up_filter = function () { } else { // Filter table items by value. - var hide = $([]); - var show = $([]); + var hidden = 0; + var shown = 0; - // Compile elements to hide / show. + // Hide / show elements. $.each(table_row_names, function () { var element = $(this).parents("tr"); if ($(this).text().indexOf(filter_value) === -1) { // hide - hide = hide.add(element); + element.addClass("hidden"); + hidden++; } else { // show - show = show.add(element); + element.removeClass("hidden"); + shown++; } }); - // Perform DOM manipulation. - hide.addClass("hidden"); - show.removeClass("hidden"); - // Show placeholder if no rows will be displayed. if (no_rows.length > 0) { - if (show.length === 0) { + if (shown === 0) { // Show placeholder, hide table. no_rows.show(); table.hide(); @@ -109,7 +107,7 @@ coverage.wire_up_filter = function () { } // Manage dynamic header: - if (hide.length > 0) { + if (hidden > 0) { // Calculate new dynamic sum values based on visible rows. for (var column = 2; column < 20; column++) { // Calculate summed value. diff --git a/doc/sample_html/coverage_html.js b/doc/sample_html/coverage_html.js index 51904dd..f6f5de2 100644 --- a/doc/sample_html/coverage_html.js +++ b/doc/sample_html/coverage_html.js @@ -73,30 +73,28 @@ coverage.wire_up_filter = function () { } else { // Filter table items by value. - var hide = $([]); - var show = $([]); + var hidden = 0; + var shown = 0; - // Compile elements to hide / show. + // Hide / show elements. $.each(table_row_names, function () { var element = $(this).parents("tr"); if ($(this).text().indexOf(filter_value) === -1) { // hide - hide = hide.add(element); + element.addClass("hidden"); + hidden++; } else { // show - show = show.add(element); + element.removeClass("hidden"); + shown++; } }); - // Perform DOM manipulation. - hide.addClass("hidden"); - show.removeClass("hidden"); - // Show placeholder if no rows will be displayed. if (no_rows.length > 0) { - if (show.length === 0) { + if (shown === 0) { // Show placeholder, hide table. no_rows.show(); table.hide(); @@ -109,7 +107,7 @@ coverage.wire_up_filter = function () { } // Manage dynamic header: - if (hide.length > 0) { + if (hidden > 0) { // Calculate new dynamic sum values based on visible rows. for (var column = 2; column < 20; column++) { // Calculate summed value. |