Add upper constraints to glanceclient

This will force pip install to use the upper-constraints.txt specified
version of pip modules. When you don't do this, you are out on the
bleeding edge and become unstable everytime some python library in the
world changes in a way that you don't expect.

The script is needed because it cleans up the conflicting entry that
corresponds to the client before applying it to source based installation.

Change-Id: I8f168fde04bf9e421d9a39e91a041512bf4f2b79
Closes-Bug: 1563038

1 files changed, 11 insertions, 1 deletions

diff --git a/tox.ini b/tox.ini
index df181c3..db9ae3f 100644
--- a/tox.ini
+++ b/tox.ini
@@ -5,7 +5,8 @@ skipsdist = True
 
 [testenv]
 usedevelop = True
-install_command = pip install -U {opts} {packages}
+install_command =
+    {toxinidir}/tools/tox_install.sh {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}
 setenv = VIRTUAL_ENV={envdir}
          OS_STDOUT_NOCAPTURE=False
          OS_STDERR_NOCAPTURE=False
@@ -19,6 +20,9 @@ commands = python setup.py testr --testr-args='{posargs}'
 commands = flake8
 
 [testenv:venv]
+# NOTE(NiallBunting) Infra does not support constraints for the venv
+# job.
+install_command = pip install -U {opts} {packages}
 commands = {posargs}
 
 [pbr]
@@ -31,6 +35,10 @@ setenv =
   OS_TEST_PATH = ./glanceclient/tests/functional
 
 [testenv:cover]
+# NOTE(NiallBunting) Infra does not support constraints for the cover
+# job. While the file is set no file is there. Can be removed once infra
+# changes this.
+install_command = pip install -U {opts} {packages}
 commands = python setup.py testr --coverage --testr-args='{posargs}'
 
 [testenv:docs]
@@ -38,6 +46,8 @@ commands=
     python setup.py build_sphinx
 
 [testenv:releasenotes]
+# NOTE(Niall Bunting) Does not support constraints.
+install_command = pip install -U {opts} {packages}
 commands = sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html
 
 [flake8]