LP#1743655: Fix up behaviour when None is passed into QName(): reject (None, None), ignore None as namespace.

1 files changed, 12 insertions, 0 deletions

diff --git a/src/lxml/tests/test_etree.py b/src/lxml/tests/test_etree.py
index 38307796..e5bd0293 100644
--- a/src/lxml/tests/test_etree.py
+++ b/src/lxml/tests/test_etree.py
@@ -179,8 +179,17 @@ class ETreeOnlyTestCase(HelperTestCase):
     def test_qname_empty(self):
         QName = self.etree.QName
         self.assertRaises(ValueError, QName, '')
+        self.assertRaises(ValueError, QName, None)
+        self.assertRaises(ValueError, QName, None, None)
         self.assertRaises(ValueError, QName, 'test', '')
 
+    def test_qname_none(self):
+        QName = self.etree.QName
+        q = QName(None, 'TAG')
+        self.assertEqual('TAG', q)
+        self.assertEqual('TAG', q.localname)
+        self.assertEqual(None, q.namespace)
+
     def test_qname_colon(self):
         QName = self.etree.QName
         self.assertRaises(ValueError, QName, 'p:name')
@@ -208,7 +217,10 @@ class ETreeOnlyTestCase(HelperTestCase):
 
         qname2 = QName(a)
         self.assertEqual(a.tag, qname1.text)
+        self.assertEqual(a.tag, qname1)
         self.assertEqual(qname1.text, qname2.text)
+        self.assertEqual(qname1, qname2.text)
+        self.assertEqual(qname1.text, qname2)
         self.assertEqual(qname1, qname2)
 
     def test_qname_text_resolve(self):