summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2012-08-22 21:43:45 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2012-08-22 21:43:45 -0400
commit4ebc3c9cfab406bcd03fb6fad84941dc0df81fdf (patch)
tree11b10c0da7cc27246f1b2752629186ee6db90102
parent385b88ff05645991fc668a1e69b04ab54acff461 (diff)
downloadalembic-4ebc3c9cfab406bcd03fb6fad84941dc0df81fdf.tar.gz
- changelog + support for remove autoinc
-rw-r--r--CHANGES4
-rw-r--r--alembic/ddl/mysql.py2
-rw-r--r--tests/test_mysql.py9
3 files changed, 14 insertions, 1 deletions
diff --git a/CHANGES b/CHANGES
index d22b4f1..7f37ef8 100644
--- a/CHANGES
+++ b/CHANGES
@@ -4,6 +4,10 @@
didn't work if the server_default was a generated
SQL expression. Courtesy Moriyoshi Koizumi.
+- [feature] Added support for alteration of MySQL
+ columns that have AUTO_INCREMENT, as well as enabling
+ this flag. Courtesy Moriyoshi Koizumi.
+
0.3.6
=====
- [feature] Added include_symbol option to
diff --git a/alembic/ddl/mysql.py b/alembic/ddl/mysql.py
index 012aae3..1f04f2a 100644
--- a/alembic/ddl/mysql.py
+++ b/alembic/ddl/mysql.py
@@ -98,7 +98,7 @@ def _mysql_colspec(compiler, name, nullable, server_default, type_,
compiler.dialect.type_compiler.process(type_),
"NULL" if nullable else "NOT NULL"
)
- if autoincrement is not None:
+ if autoincrement:
spec += " AUTO_INCREMENT"
if server_default != False:
spec += " DEFAULT %s" % _render_value(compiler, server_default)
diff --git a/tests/test_mysql.py b/tests/test_mysql.py
index 28c1fd6..456aab7 100644
--- a/tests/test_mysql.py
+++ b/tests/test_mysql.py
@@ -45,6 +45,15 @@ def test_col_add_autoincrement():
'ALTER TABLE t1 CHANGE c1 c2 INTEGER NULL AUTO_INCREMENT'
)
+def test_col_remove_autoincrement():
+ context = op_fixture('mysql')
+ op.alter_column('t1', 'c1', name="c2", existing_type=Integer,
+ existing_autoincrement=True,
+ autoincrement=False)
+ context.assert_(
+ 'ALTER TABLE t1 CHANGE c1 c2 INTEGER NULL'
+ )
+
def test_col_nullable():
context = op_fixture('mysql')
op.alter_column('t1', 'c1', nullable=False, existing_type=Integer)