summaryrefslogtreecommitdiff
path: root/alembic/autogenerate
diff options
context:
space:
mode:
authorFederico Caselli <cfederico87@gmail.com>2023-05-11 21:49:14 +0200
committerFederico Caselli <cfederico87@gmail.com>2023-05-11 22:41:09 +0200
commit230a2932f646800b006c00b434be95c164598525 (patch)
tree03b4b3b665b41461798b54c3a0b29ff9b7cdec75 /alembic/autogenerate
parent92e54a0e1c96cecd99397cb1aee9c3bb28f780c6 (diff)
downloadalembic-230a2932f646800b006c00b434be95c164598525.tar.gz
Removed server default quoting from compare
Don't modify the metadata server default when comparing it in the autogenerate process. This impacts the value passes to user provided functions passed in :paramref:`.EnvironmentContext.configure.compare_server_default` and third party dialect that implement a custom ``compare_server_default``. Fixes: #1178 Change-Id: Ib429efcf9077337f768ad5aad91659867e89391a
Diffstat (limited to 'alembic/autogenerate')
-rw-r--r--alembic/autogenerate/compare.py12
1 files changed, 3 insertions, 9 deletions
diff --git a/alembic/autogenerate/compare.py b/alembic/autogenerate/compare.py
index 595631c..b489328 100644
--- a/alembic/autogenerate/compare.py
+++ b/alembic/autogenerate/compare.py
@@ -1023,9 +1023,7 @@ def _compare_type(
def _render_server_default_for_compare(
- metadata_default: Optional[Any],
- metadata_col: Column,
- autogen_context: AutogenContext,
+ metadata_default: Optional[Any], autogen_context: AutogenContext
) -> Optional[str]:
if isinstance(metadata_default, sa_schema.DefaultClause):
@@ -1039,11 +1037,7 @@ def _render_server_default_for_compare(
)
)
if isinstance(metadata_default, str):
- if metadata_col.type._type_affinity is sqltypes.String:
- metadata_default = re.sub(r"^'|'$", "", metadata_default)
- return f"'{metadata_default}'"
- else:
- return metadata_default
+ return metadata_default
else:
return None
@@ -1190,7 +1184,7 @@ def _compare_server_default(
)
else:
rendered_metadata_default = _render_server_default_for_compare(
- metadata_default, metadata_col, autogen_context
+ metadata_default, autogen_context
)
rendered_conn_default = (