summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--ChangeLog1
-rw-r--r--astroid/nodes/node_classes.py40
-rw-r--r--astroid/rebuilder.py6
3 files changed, 6 insertions, 41 deletions
diff --git a/ChangeLog b/ChangeLog
index f92dbbee..a5de4d76 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -39,6 +39,7 @@ Release date: TBA
- ``nodes.Subscript``
- ``nodes.UnaryOp``
- ``nodes.While``
+ - ``nodes.Yield``
These changes involve breaking changes to their API but should be considered bug fixes. We
now make arguments required when they are instead of always providing defaults.
diff --git a/astroid/nodes/node_classes.py b/astroid/nodes/node_classes.py
index ae4cf632..de07b052 100644
--- a/astroid/nodes/node_classes.py
+++ b/astroid/nodes/node_classes.py
@@ -3825,44 +3825,10 @@ class Yield(NodeNG):
_astroid_fields = ("value",)
- def __init__(
- self,
- lineno: int | None = None,
- col_offset: int | None = None,
- parent: NodeNG | None = None,
- *,
- end_lineno: int | None = None,
- end_col_offset: int | None = None,
- ) -> None:
- """
- :param lineno: The line that this node appears on in the source code.
-
- :param col_offset: The column that this node appears on in the
- source code.
-
- :param parent: The parent node in the syntax tree.
-
- :param end_lineno: The last line this node appears on in the source code.
-
- :param end_col_offset: The end column this node appears on in the
- source code. Note: This is after the last symbol.
- """
- self.value: NodeNG | None = None # can be None
- """The value to yield."""
-
- super().__init__(
- lineno=lineno,
- col_offset=col_offset,
- end_lineno=end_lineno,
- end_col_offset=end_col_offset,
- parent=parent,
- )
-
- def postinit(self, value: NodeNG | None = None) -> None:
- """Do some setup after initialisation.
+ value: NodeNG | None
+ """The value to yield."""
- :param value: The value to yield.
- """
+ def postinit(self, value: NodeNG | None) -> None:
self.value = value
def get_children(self):
diff --git a/astroid/rebuilder.py b/astroid/rebuilder.py
index 61fbf444..c7a940cd 100644
--- a/astroid/rebuilder.py
+++ b/astroid/rebuilder.py
@@ -1949,8 +1949,7 @@ class TreeRebuilder:
end_col_offset=getattr(node, "end_col_offset", None),
parent=parent,
)
- if node.value is not None:
- newnode.postinit(self.visit(node.value, newnode))
+ newnode.postinit(self.visit(node.value, newnode))
return newnode
def visit_yieldfrom(self, node: ast.YieldFrom, parent: NodeNG) -> NodeNG:
@@ -1962,8 +1961,7 @@ class TreeRebuilder:
end_col_offset=getattr(node, "end_col_offset", None),
parent=parent,
)
- if node.value is not None:
- newnode.postinit(self.visit(node.value, newnode))
+ newnode.postinit(self.visit(node.value, newnode))
return newnode
if sys.version_info >= (3, 10):